← Back to issue list

Backport to 1.x: Replace use of `assert_not_called` in the catkin tests

View original Github issue

Metadata

Project
snapcraft
Number
#219
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line.

Suggested action: —

No scores available.

Issue body

Backport of #200 to 1.x.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line.
qwen3.6-35b-a3b-mtp-q6 — — Merged a backport of PR #200 to the 1.x branch, replacing assert_not_called usage in catkin tests to align with updated testing standards.
qwen3.6-35b-a3b-mtp-q6 — — Merged a backport of PR #200 to the 1.x branch, replacing assert_not_called usage in catkin tests. Maintainer kyrofa applied the change to align test assertions with updated testing standards.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#181 Backport to 1.x: Resolve FIXME in Catkin plugin snapcraft merged Merged a backport of PR #158 to the 1.x branch, resolving a FIXME in the Catkin plugin. The update modified two files with a net change of -3 lines.
79%
#292 Backport to 1.x: Fix ordering for conditional negations in catkin tests snapcraft merged Merged as a backport of #199 to the 1.x branch. Resolves an ordering issue with conditional negations in catkin tests. Approved by @sergiusens and verified after retriggering example tests.
77%
#184 Backport to 1.x: Catkin plugin: Refactor build. snapcraft merged Merged backport of PR #175 to the 1.x branch, refactoring the Catkin plugin build across three files. Changes applied directly without reviewer comments or CI checks.
76%
#196 Backport to 1.x: Catkin plugin: Improve cmake path rewrite. snapcraft merged Merged backport of PR #195 to the 1.x branch. Updates the Catkin plugin to improve cmake path rewriting, changing two files (+57/-35).
74%