Backport to 1.x: Replace use of `assert_not_called` in the catkin tests
Metadata
Current evaluation
Merged into 1.x as PR #219, backporting #200 to replace assert_not_called() with assertFalse(mock.called) in catkin tests while preserving custom failure messages.
Resolution: closed resolved
Reason: PR #219 was merged into the 1.x branch. It backported PR #200, whose change was merged in commit 9c5b83418 with implementation commit 50b9537ce.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Backport of #200 to 1.x.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into 1.x as PR #219, backporting #200 to replace assert_not_called() with assertFalse(mock.called) in catkin tests while preserving custom failure messages. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into 1.x, backporting #200 to replace assert_not_called with assertFalse(mock.called) in catkin tests, preserving custom error messages. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged PR #200 backport to the 1.x branch, replacing assert_not_called calls in catkin tests. The change updated one file with six additions and three deletions, successfully applying the test fix to the legacy release line. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a backport of PR #200 to the 1.x branch, replacing assert_not_called usage in catkin tests to align with updated testing standards. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#200
(confidence 100%)
Original PR backported by #219; merged as commit 9c5b83418.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #200 Replace use of `assert_not_called` in the catkin tests | snapcraft | merged | Merged PR #200 via commit 9c5b83418 (change 50b9537ce): replaced assert_not_called with assertFalse(mock.called) in catkin tests to preserve custom failure messages. | |
| #292 Backport to 1.x: Fix ordering for conditional negations in catkin tests | snapcraft | merged | Merged into snapcraft 1.x via PR #292, backporting PR #199’s two-line fix for conditional-negation ordering in catkin tests. | |
| #184 Backport to 1.x: Catkin plugin: Refactor build. | snapcraft | merged | PR #184 merged into 1.x, backporting #175’s Catkin build refactor to simplify build logic and dependency handling. |