patches: make the ctypes patch more robust and add armhf arch triplet
Metadata
Current evaluation
Closed unmerged after the ctypes fix still failed; its armhf library-loading change was superseded by merged #2126 (commit 5230460c7).
Resolution: closed superseded
Reason: PR #2003 was closed unmerged after a reviewer reported that the ctypes change still failed. Equivalent armhf handling landed through merged PR #2126 in commit 5230460c7.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Explode appropriately if the environment is incorrect to avoid
going down the line of why it broke later due to a bad environment
being setup.
Also add the correct architecture triplet resolution for when SNAP_ARCH
is armhf.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after the ctypes fix still failed; its armhf library-loading change was superseded by merged #2126 (commit 5230460c7). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review found the ctypes patch still failed; its armhf library-loading change later landed via #2126 (commit 5230460c7). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after review reported the ctypes fix was still failing. Equivalent armhf library handling landed through snapcraft/snapcraft#2126 in commit 5230460c7. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated the ctypes patch to validate the build environment and added armhf architecture triplet resolution. Approved by reviewer with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed without merging after a reviewer reported continued failures, despite maintainer claims of updates. The changes aimed to improve ctypes patch robustness and add armhf architecture triplet support. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#2126
(confidence 99%)
Merged PR #2126 added correct armhf ctypes library handling in commit 5230460c7.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2126 packaging: load the correct libraries on armhf | snapcraft | merged | Merged #2126 in commit 5230460c7, adding armhf handling so packaging loads the correct architecture-specific libraries for ctypes. | |
| #2076 patches: improve ctypes patch for python 3.5 | snapcraft | merged | Merged PR #2076 in commit 8e97ee8bd, improving Snapcraft's ctypes patch for Python 3.5 across four files. |