patches: improve ctypes patch for python 3.5
Metadata
Current evaluation
Merged PR #2076 in commit 8e97ee8bd, improving Snapcraft's ctypes patch for Python 3.5 across four files.
Resolution: closed resolved
Reason: PR #2076 was merged as commit 8e97ee8bd, confirming the Python 3.5 ctypes patch improvements landed. The separately encountered Python plugin error was fixed by #2077.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2076 in commit 8e97ee8bd, improving Snapcraft's ctypes patch for Python 3.5 across four files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft PR #2076, improving the ctypes patch for Python 3.5 and updating four files. A separate Python plugin error was addressed by #2077. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updates the ctypes patch for Python 3.5. A related plugin error was resolved by PR #2077. The change modifies 4 files, adding 39 lines and removing 10. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvement to the ctypes patch for Python 3.5. Resolves a potential error in the python plugin, with related fixes addressed in PR #2077. Passed static and unit tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2077
(confidence 98%)
The author identified this merged PR as the fix for a separate Python plugin error found alongside the ctypes changes.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1915 snap: patch ctypes for the snap | snapcraft | merged | Merged PR #1915 via commit 1049173eb, patching ctypes for snap builds and removing the bundled libarchive dependency. | |
| #2003 patches: make the ctypes patch more robust and add armhf arch triplet | snapcraft | closed | Closed unmerged after the ctypes fix still failed; its armhf library-loading change was superseded by merged #2126 (commit 5230460c7). |