pluginhandler: only do elf checking and patching for type app
Metadata
Current evaluation
Merged changes restricting ELF checking and patching to app-type snaps, removing unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Approved and passed CI.
Suggested action: —
No scores available.
Issue body
If the snap is not of type app, today, it is not necessary to do
ABI/API checks agains libc6.
LP: #1757094
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes restricting ELF checking and patching to app-type snaps, removing unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Restricts ELF checking and patching to snap type app, skipping unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Verified by ondra. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after successful testing. Restricts ELF checking and patching to snap type app, eliminating unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2021 pluginhandler: only resort to elf mangling if the snap type is app | snapcraft | merged | Merged a fix restricting ELF mangling to app-type snaps only. Approved, passed CI, and updated one file with 12 additions and 4 deletions. | |
| #1850 pluginhandler: patch and handle elf files on glibc mismatch | snapcraft | merged | Merged. Resolves glibc mismatches in ELF files by fetching libc6 from the host, priming it, and using its dynamic loader instead of the base snap's. Approved by two reviewers and closes issues #1668 and #1669. | |
| #3277 pluginhandler: support using patchelf on strict snaps | snapcraft | merged | Adds enable-patchelf build attribute to opt into rpath and interpreter patching for strict snaps. Feature applies per-part. Review resolved naming and command-chain handling. Merged following a commit revert. | |
| #2926 plugin handler: process elf files only if base is specified | snapcraft | merged | Merged. Prevents ELF file processing when no base is specified, resolving snapd build failures without an explicit type. Approved by reviewers, passed CI, and unblocked downstream snapd development. | |
| #2337 pluginhandler: library detection instead of injection | snapcraft | merged | Merged. Replaced host binary injection with library detection via base snaps, converting missing library errors to warnings. Approved by reviewer and passed CI checks. |