pluginhandler: only do elf checking and patching for type app
Metadata
Current evaluation
Merged PR #2012 in commit eae356003, limiting ELF/libc ABI/API checks and patching to app-type snaps and avoiding unnecessary checks for other snap types.
Resolution: closed resolved
Reason: Resolved by merged PR #2012 (commit eae356003), which restricts ELF/libc ABI/API checks and patching to app-type snaps. The change directly addresses LP #1757094.
Evaluated by: mr-cal-bot
No scores available.
Issue body
If the snap is not of type app, today, it is not necessary to do
ABI/API checks agains libc6.
LP: #1757094
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2012 in commit eae356003, limiting ELF/libc ABI/API checks and patching to app-type snaps and avoiding unnecessary checks for other snap types. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#2012 (eae356003), restricting ELF/libc ABI/API checks and patching to app-type snaps and addressing unnecessary validation of non-app snaps (LP #1757094). | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes restricting ELF checking and patching to app-type snaps, removing unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Approved and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Restricts ELF checking and patching to snap type app, skipping unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Verified by ondra. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2021 pluginhandler: only resort to elf mangling if the snap type is app | snapcraft | merged | Merged #2021 in commit b4a07ba58, limiting ELF mangling to app-type snaps so non-app snaps are left unprocessed. | |
| #3277 pluginhandler: support using patchelf on strict snaps | snapcraft | merged | Merged PR #3277 as fd8e95c3d, adding per-part enable-patchelf support to patch ELF rpaths and interpreters in strictly confined snaps. | |
| #1850 pluginhandler: patch and handle elf files on glibc mismatch | snapcraft | merged | Merged in snapcraft#1850 (bdaf0b7f1), adding host libc6 staging and its dynamic loader when ELF files need newer glibc; fixes #1668 and #1669. | |
| #1979 pluginhandler: simplify logic when elf patching is required | snapcraft | merged | Merged PR #1979 as commit 5fd7e3c30, simplifying pluginhandler ELF-patching detection and related tests across six files. | |
| #2005 pluginhandler: special case go patchelf failures for classic confinement | snapcraft | merged | Merged PR #2005, making PatchELF failures for classic-confined Go snaps non-fatal warnings and cleaning up base/libc6 stage-package handling. | |
| #2926 plugin handler: process elf files only if base is specified | snapcraft | merged | PR #2926 merged into snapcraft master as commit 9b1655d02: the plugin handler now processes ELF files only when a base is specified, unblocking snapd builds (LP #1857019). |