pluginhandler: only resort to elf mangling if the snap type is app
Metadata
Current evaluation
Merged #2021 in commit b4a07ba58, limiting ELF mangling to app-type snaps so non-app snaps are left unprocessed.
Resolution: closed resolved
Reason: PR canonical/snapcraft#2021 was merged and landed as commit b4a07ba58, adding a snap-type check before ELF mangling.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
We should not be doing crazy things with things like https://code.launchpad.net/~mvo/+snap/core18
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2021 in commit b4a07ba58, limiting ELF mangling to app-type snaps so non-app snaps are left unprocessed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2021 in commit b4a07ba58, limiting ELF mangling to app-type snaps and preventing unintended processing of non-app snaps such as core18 bases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2021: ELF mangling now runs only for app-type snaps, avoiding unintended processing of other snap types (commit b4a07ba58). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2021 (b4a07ba58), limiting ELF mangling to app snaps to avoid modifying base snaps such as core18. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix restricting ELF mangling to app-type snaps only. Approved, passed CI, and updated one file with 12 additions and 4 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to pluginhandler restricting ELF mangling to snap type app only. This prevents unnecessary binary modifications for non-app snaps like core18. Authored by maintainer sergiusens and passed static and unit tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2012 pluginhandler: only do elf checking and patching for type app | snapcraft | merged | Merged PR #2012 in commit eae356003, limiting ELF/libc ABI/API checks and patching to app-type snaps and avoiding unnecessary checks for other snap types. | |
| #2926 plugin handler: process elf files only if base is specified | snapcraft | merged | PR #2926 merged into snapcraft master as commit 9b1655d02: the plugin handler now processes ELF files only when a base is specified, unblocking snapd builds (LP #1857019). | |
| #1850 pluginhandler: patch and handle elf files on glibc mismatch | snapcraft | merged | Merged in snapcraft#1850 (bdaf0b7f1), adding host libc6 staging and its dynamic loader when ELF files need newer glibc; fixes #1668 and #1669. |