pluginhandler: only resort to elf mangling if the snap type is app
Metadata
Current evaluation
Merged a fix restricting ELF mangling to app-type snaps only. Approved, passed CI, and updated one file with 12 additions and 4 deletions.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
We should not be doing crazy things with things like https://code.launchpad.net/~mvo/+snap/core18
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix restricting ELF mangling to app-type snaps only. Approved, passed CI, and updated one file with 12 additions and 4 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes to pluginhandler restricting ELF mangling to snap type app only. This prevents unnecessary binary modifications for non-app snaps like core18. Authored by maintainer sergiusens and passed static and unit tests. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix restricting ELF mangling in pluginhandler to snap type app only, preventing unintended modifications to system snaps like core18. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2012 pluginhandler: only do elf checking and patching for type app | snapcraft | merged | Merged changes restricting ELF checking and patching to app-type snaps, removing unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Approved and passed CI. | |
| #2926 plugin handler: process elf files only if base is specified | snapcraft | merged | Merged. Prevents ELF file processing when no base is specified, resolving snapd build failures without an explicit type. Approved by reviewers, passed CI, and unblocked downstream snapd development. | |
| #1850 pluginhandler: patch and handle elf files on glibc mismatch | snapcraft | merged | Merged. Resolves glibc mismatches in ELF files by fetching libc6 from the host, priming it, and using its dynamic loader instead of the base snap's. Approved by two reviewers and closes issues #1668 and #1669. | |
| #1976 elf: only consider regular files as possible ELF binaries | snapcraft | merged | Merged a fix restricting ELF binary detection to regular files, resolving Snapcraft core snap build failures caused by device files being misidentified. Approved by reviewers and passed CI checks. | |
| #3277 pluginhandler: support using patchelf on strict snaps | snapcraft | merged | Adds enable-patchelf build attribute to opt into rpath and interpreter patching for strict snaps. Feature applies per-part. Review resolved naming and command-chain handling. Merged following a commit revert. | |
| #1979 pluginhandler: simplify logic when elf patching is required | snapcraft | merged | Merged changes simplifying ELF patching logic in the pluginhandler. The update reduced code by 38 lines across six files, received reviewer approval, and passed checks before integration. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage. |