← Back to issue list

integration tests: snap tests shouldn't be arch-specific

View original Github issue

Metadata

Project
snapcraft
Number
#2014
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`?

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
qwen3.6-35b-a3b-mtp-q6 Integration tests were updated to remove architecture-specific constraints, enabling execution across all supported architectures. The maintainer merged the changes after passing static and unit test suites.
qwen3.6-35b-a3b-mtp-q6 Merged a pull request to remove architecture-specific constraints from integration snap tests, ensuring they run across all supported architectures.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1378 Integration tests for snap command with target arch snapcraft merged Merged. Adds integration tests for the snap command with --target-arch, fixing silent flag ignoring when placed before the snap subcommand and missing help text. Approved by two reviewers, four files changed.
81%
#1849 tests: add snap not found tests snapcraft merged Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts.
76%
#554 Support running the snaps tests in multiple architectures snapcraft merged Merged to enable snaps tests across multiple architectures. Modified one file with four additions and two deletions. Resolved after maintainer requested a retest.
76%
#1595 tests: fix the skip of snapd integration tests in armhf snapcraft merged Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.
76%
#990 tests: fix snaps tests in armhf snapcraft merged Merged into master to fix failing snap tests on the armhf architecture. Approved by a reviewer, the change updated 11 files and resolved CI failures without altering overall code coverage.
74%
#1542 tests: add integration tests for build snaps snapcraft merged Merged integration tests for build snaps. Approved by two reviewers and passed CI. Two test scenarios omitted due to known bugs.
74%
#314 Replace dpkg-architecure calls in tests snapcraft merged Merged changes replacing dpkg-architecture calls in tests with snapcraft.common imports to improve dependency detection in snapcraft.yaml. Approved by maintainers after resolving a minor import style discussion.
74%
#150 inspectors/snap: add additional inspector tests fetch-service merged Merged after approval by two reviewers. The pull request adds additional inspector tests for snap. Successfully integrated into the main branch.
74%
#2421 tests: remove obsolete snap and external tests snapcraft merged Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation.
73%
#2266 integration tests: disable tests using snaps in bionic container snapcraft merged Merged changes disabling integration tests using snaps in bionic containers to address reported failures. The +7/-1 line update across two files passed CI and received reviewer approval.
73%