tests: fix the skip of snapd integration tests in armhf
Metadata
Current evaluation
Merged #1595 (8db14753d), fixing armhf snapd integration-test skips by checking self.deb_arch only after the parent setUp initialized it.
Resolution: closed resolved
Reason: PR #1595 was merged as commit 8db14753d, correcting test setup so self.deb_arch is accessed only after the parent setUp initializes it.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
A little mistake here on my side: `self.deb_arch` is only available after calling the parent `setUp`. Sorry about that.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #1595 (8db14753d), fixing armhf snapd integration-test skips by checking self.deb_arch only after the parent setUp initialized it. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in #1595 (commit 8db14753d), fixing armhf snapd integration-test skips by accessing self.deb_arch only after the parent setUp. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for skipping snapd integration tests on armhf. self.deb_arch was accessed before calling the parent setUp method. Corrected the initialization order so the attribute is available during test setup. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #990 tests: fix snaps tests in armhf | snapcraft | merged | Merged PR #990 as commit f467e55bc, correcting armhf failures in snap tests across 11 files and closing Launchpad bug #1650458. | |
| #971 tests: fix integration tests in armhf | snapcraft | merged | Merged PR #971 as commit a725e69da, fixing armhf integration-test setup with architecture-specific test configuration. | |
| #1649899 integration tests fail in armhf | snapcraft (launchpad) | closed | Armhf integration tests were fixed and re-enabled by merged PR snapcore/snapcraft#971 (commit a725e69da). | |
| #917 Fix unittests in armhf | snapcraft | closed | armhf unit-test fixes PR closed unmerged by come-maiz in favor of #945, which split integration and snaps tests onto separate branches; #945 was later merged as commit 073332b9b. | |
| #945 Fix unittests in armhf | snapcraft | merged | Merged PR #945 as commit 073332b9b, making Snapcraft unit tests architecture-agnostic so they pass on armhf. | |
| #2014 integration tests: snap tests shouldn't be arch-specific | snapcraft | merged | Merged #2014 in commit fd176f3bc, removing architecture-specific constraints from snap integration tests so they run across architectures. | |
| #1430 tests: enable the snaps installation in armhf | snapcraft | closed | PR #1430 was closed unmerged as stale WIP; its attempt to enable snap-installation tests on armhf was abandoned after the change stopped working. | |
| #1378 Integration tests for snap command with target arch | snapcraft | merged | PR #1378 merged as 18a767537, fixing --target-arch parsing before the snap subcommand and adding integration tests for invocation forms. | |
| #1650458 snaps tests fail in armhf | snapcraft (launchpad) | closed | Armhf snap test builds were fixed by snapcore/snapcraft#990, merged as f467e55bc; installation testing remained deferred because runners used LXC. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged #4755, fixing the devel-base integration test to verify Snapcraft can create the base snap and that the resulting devel base is usable. |