← Back to issue list

tests: fix the skip of snapd integration tests in armhf

View original Github issue

Metadata

Project
snapcraft
Number
#1595
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- A little mistake here on my side: `self.deb_arch` is only available after calling the parent `setUp`. Sorry about that.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp caused failures. Correcting the initialization order resolved the issue. Approved by one reviewer and passed CI.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for skipping snapd integration tests on armhf. self.deb_arch was accessed before calling the parent setUp method. Corrected the initialization order so the attribute is available during test setup.
qwen3.6-35b-a3b-mtp-q6 Merged fix for snapd integration test skipping on armhf. Accessing self.deb_arch before the parent setUp method caused failures. Resolved by ensuring proper initialization order before attribute access.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#990 tests: fix snaps tests in armhf snapcraft merged Merged into master to fix failing snap tests on the armhf architecture. Approved by a reviewer, the change updated 11 files and resolved CI failures without altering overall code coverage.
82%
#1822 tests: skip classic confined tests on armhf snapcraft merged Merged. Skips classic confined tests on armhf architecture because a snapcraft deb requirement to install patchelf from the snapstore disabled them. Approved by one reviewer and merged with a +14/-6 change across seven files.
78%
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
76%
#917 Fix unittests in armhf snapcraft closed Closed in favor of PR #945 to split integration and snaps tests into separate branches. Original changes addressed armhf unittest failures after test machine configuration updates.
74%
#145 fix: fix tests on arm64 craft-archives merged Merged to fix arm64 test failures. Approved by two reviewers and integrated after passing most CI checks, despite a failing OSV-scanner. Resolves #143 and #144 with a 32-line change across two files.
74%
#774 build(snap): update stage-packages for armhf rockcraft merged Merged an update to snap stage-packages for armhf, replacing unavailable libgpgme11 and libbtrfs0 with t64 variants. Approved by two reviewers, passed CI, and modified 2 lines in 1 file.
73%
#971 tests: fix integration tests in armhf snapcraft merged Merged to master after approval and passing CI. The patch fixes integration tests on armhf architecture. Reviewers approved the change but recommended using project_options over platform.machine for future architectural consistency. Code coverage remained stable at 96.39%.
72%
#557 build: fix snap build in non-amd64 archs rockcraft merged Merged fix for snap builds on non-amd64 architectures, resolving missing dependency wheels. Approved by two reviewers, passed CI, and updated one file with 15 lines.
72%
#2173 fix(snap): fix build on 32-bit platforms charmcraft merged Merged a one-line fix resolving snap build failures on 32-bit armhf platforms. Approved by three reviewers and validated via a successful Launchpad remote build.
72%
#4755 tests: fix devel base snap test snapcraft merged Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change.
72%