← Back to issue list

storeapi: handle 5xx error codes for all store endpoints

View original Github issue

Metadata

Project
snapcraft
Number
#2116
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2116 as commit c6500ca0e, generalizing Store API 5xx handling across all endpoints and fixing LP #1768370.

Resolution: closed resolved

Reason: PR #2116 was merged as commit c6500ca0e. Its change applies robust handling of Store API 5xx responses to every endpoint and resolves LP #1768370.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Currently, the snapcraft CLI handles a 500 response when releasing a snap. This PR fixes [LP: #1768370](https://bugs.launchpad.net/snapcraft/+bug/1768370) by making this more robust, and nicely handling 5xx codes for all endpoints.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2116 as commit c6500ca0e, generalizing Store API 5xx handling across all endpoints and fixing LP #1768370.
stealth/space-bunny-alpha — closed resolved Merged PR #2116 as commit c6500ca0e, generalizing Store API 5xx handling to every endpoint and fixing LP #1768370.
qwen/qwen3.6-35b-a3b — — Merged robust 5xx error handling across all store API endpoints. Fixes Launchpad bug #1768370 by generalizing release-specific error handling. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes extending 5xx error handling from the release endpoint to all store API endpoints, resolving LP: #1768370 and improving API error robustness.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#2059 (confidence 98%)

    Earlier merged PR handled HTTP 500 responses during snap release; #2116 generalized that behavior to all Store API endpoints.

Related issues

Issue Project State Summary Similarity
#1936 storeapi: handle errors even for >400 responses snapcraft merged Merged PR #1936 (688588a0d) fixed Store API error handling for HTTP responses above 400, preventing failed responses from being mistaken for missing responses.
79%
#2094 storeapi: better handle network errors and retries snapcraft merged Merged #2094 as 0d8602cc5, silencing urllib retry warnings and handling Store API connection failure after retry exhaustion without a traceback; fixes LP #1765671.
73%
#3667 storeapi: fix typo snapcraft merged Merged PR #3667 via commit 911bf4698 (merge 0224b48ea), correcting a typo in the storeapi module.
73%
#3550 storeapi: log responses and registration error code snapcraft merged Merged #3550 via 29dd2455d, adding debug logging for Store API responses and surfacing registration error codes.
72%
#3562 storeapi: improve candid interaction errors (CRAFT-135) snapcraft merged Merged #3562 via e2640b1bd (merge 54781044a), adding distinct Store API errors and messages for token-related candid interactions.
70%