storeapi: log responses and registration error code
Metadata
Current evaluation
Merged #3550 via 29dd2455d, adding debug logging for Store API responses and surfacing registration error codes.
Resolution: closed resolved
Reason: PR #3550 was merged into master by merge commit 29dd2455d. Implementing commit a12c0b92f logs response text in debug mode and prints registration error codes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
All responses are now logged in debug mode (response.text) and the error
code is properly printed out on registration errors.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
A very minimal change PR in case we need to cherry pick it to an older release
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #3550 via 29dd2455d, adding debug logging for Store API responses and surfacing registration error codes. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3550 via a12c0b92f: Store API responses are debug-logged with response.text, and registration failures now report the error code. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3550 in commit 29dd2455d, adding debug logs for Store API responses and printing registration error codes. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #3550 (branch 4.8.3-store-log) by sergiusens merged via commit 29dd2455d (head a12c0b9): storeapi now logs responses in debug mode and prints the error code on registration errors. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #3550 via 29dd2455d: Store API responses now appear in debug logs, and registration failures print their error code. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds debug logging for store API responses and improves registration error code output. The minimal change (+16/-5 lines, 4 files) passed CI, achieved 100% coverage, and was approved for backporting. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Implements debug logging for API responses and prints registration error codes. The minimal change is marked for potential cherry-picking to older releases and increased unit test coverage by 0.24%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1936 storeapi: handle errors even for >400 responses | snapcraft | merged | Merged PR #1936 (688588a0d) fixed Store API error handling for HTTP responses above 400, preventing failed responses from being mistaken for missing responses. | |
| #2116 storeapi: handle 5xx error codes for all store endpoints | snapcraft | merged | Merged PR #2116 as commit c6500ca0e, generalizing Store API 5xx handling across all endpoints and fixing LP #1768370. | |
| #3562 storeapi: improve candid interaction errors (CRAFT-135) | snapcraft | merged | Merged #3562 via e2640b1bd (merge 54781044a), adding distinct Store API errors and messages for token-related candid interactions. |