many: extract lifecycle ordering into own module
Metadata
Current evaluation
PR #2159 was merged as commit 6a676f202, centralizing lifecycle step names and ordering in a dedicated module and replacing duplicated logic across 18 files.
Resolution: closed resolved
Reason: The approved refactor was merged into master as commit 6a676f202. It introduced a shared lifecycle-ordering module consumed by the other components.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Currently the snapcraft CLI has step names and ordering hard-coded in a number of places, and those areas where it isn't hard-coded, a difficult-to-read index method is used. Simplify and extract this logic into a single module used by the others to determine lifecycle steps and ordering.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2159 was merged as commit 6a676f202, centralizing lifecycle step names and ordering in a dedicated module and replacing duplicated logic across 18 files. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into master in #2159, extracting hard-coded lifecycle step names and ordering into a dedicated module and simplifying consumers across 18 files. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Extracted hard-coded lifecycle step ordering from the CLI into a dedicated module, simplifying logic across 18 files. Approved by maintainer and passed CI. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Extracted hard-coded snapcraft lifecycle step ordering into a dedicated module to simplify code and improve maintainability. Approved by maintainer and passed all tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1626 lifecycle: split into its own package | snapcraft | merged | Merged PR #1626 as commit 5aab678b8, splitting the lifecycle module into its own package to separate concerns and improve navigability. |