← Back to issue list

lifecycle: split into its own package

View original Github issue

Metadata

Project
snapcraft
Number
#1626
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1626 as commit 5aab678b8, splitting the lifecycle module into its own package to separate concerns and improve navigability.

Resolution: closed resolved

Reason: PR #1626 was approved and merged as commit 5aab678b8, completing the minimally invasive lifecycle package refactor.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This is a small refactor to make the lifecycle module a bit more manageable and separate some concerns for the logic within it. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- This is as minimally invasive as possible, but required to make the lifecycle logic navigate-able again to build on top of.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1626 as commit 5aab678b8, splitting the lifecycle module into its own package to separate concerns and improve navigability.
stealth/space-bunny-alpha — closed resolved Merged PR #1626, splitting lifecycle logic into a dedicated package to improve maintainability; landed as commit 5aab678b8.
stealth/space-bunny-alpha — closed resolved Merged PR #1626 (commit 5aab678b8), splitting the lifecycle module into its own package as a minimal refactor to separate concerns and improve navigability.
qwen/qwen3.6-35b-a3b — — Merged a refactor splitting the lifecycle module into a dedicated package to improve code manageability and separation of concerns. Approved by reviewers with passing CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a refactor extracting the lifecycle module into a dedicated package. This separation improves code manageability, clarifies responsibilities, and enhances navigability for future development. Approved by @kyrofa.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2159 many: extract lifecycle ordering into own module snapcraft merged PR #2159 was merged as commit 6a676f202, centralizing lifecycle step names and ordering in a dedicated module and replacing duplicated logic across 18 files.
75%
#2040 lifecycle: always prime dependencies snapcraft closed PR #2040 was closed unmerged after a reviewer requested related lifecycle-logic changes; no resolving commit or superseding work was recorded.
71%
#27 lifecycle: move PartsLifecycle to LifecycleService craft-application merged Merged PR #27 in commit d166936f, moving PartsLifecycle into LifecycleService to centralize command business logic.
70%