← Back to issue list

many: add shellcheck to static tests

View original Github issue

Metadata

Project
snapcraft
Number
#2172
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2172 via commit 25043ab36, adding ShellCheck to static tests and updating affected scripts across 28 files.

Resolution: closed resolved

Reason: PR #2172 was merged into master as commit 25043ab36. The change introduced ShellCheck to the static-test suite and updated the affected scripts to satisfy the new checks.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- Also ensure all scripts pass. **Note:** part of the modification here involves autopkgtests, so we should probably run those once Travis is green.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2172 via commit 25043ab36, adding ShellCheck to static tests and updating affected scripts across 28 files.
stealth/space-bunny-alpha — closed resolved Merged PR #2172 into master via commit 25043ab36, adding ShellCheck to static tests and updating 28 files; the change passed CI and received approval.
qwen/qwen3.6-35b-a3b — — Merged into master. Added shellcheck to static tests to validate shell scripts across 28 files. The change passed CI, received reviewer approval, and slightly increased code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master, integrating shellcheck into static tests to validate all project scripts. The update enforces shell script linting, passed CI checks, and yielded a negligible coverage increase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#196 lint: add shellcheck and spread-shellcheck linters rockcraft merged Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes.
71%