many: add shellcheck to static tests
Metadata
Current evaluation
Merged into master. Added shellcheck to static tests to validate shell scripts across 28 files. The change passed CI, received reviewer approval, and slightly increased code coverage.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Also ensure all scripts pass. **Note:** part of the modification here involves autopkgtests, so we should probably run those once Travis is green.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Added shellcheck to static tests to validate shell scripts across 28 files. The change passed CI, received reviewer approval, and slightly increased code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, integrating shellcheck into static tests to validate all project scripts. The update enforces shell script linting, passed CI checks, and yielded a negligible coverage increase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, adding shellcheck to the static test suite. The change passed static and unit tests, slightly increased code coverage, and was approved by a maintainer. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #196 lint: add shellcheck and spread-shellcheck linters | rockcraft | merged | Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency. | |
| #3599 desktop: improve shell substitution logic | snapcraft | merged | Merged to master after passing CI and receiving two approvals. The single-line change improves shell substitution logic to resolve shellcheck error SC2295, with no coverage impact. |