lint: add shellcheck and spread-shellcheck linters
Metadata
Current evaluation
Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency.
Suggested action: —
No scores available.
Issue body
- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
-----
Add new linter for shellcheck and spread-shellcheck to the github workflow.
Includes some minor fixes to be shellcheck-compliant.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes adding shellcheck and spread-shellcheck linters to the GitHub workflow, including minor compliance fixes. Author inquired about documenting the shellcheck snap dependency for development. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added shellcheck and spread-shellcheck linters to the GitHub workflow with minor compliance fixes. Author inquired about documenting the shellcheck snap requirement for development. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #201 lint: run shellcheck on spread.yaml | rockcraft | merged | Pull request to run shellcheck on spread.yaml was approved, passed CI, and merged with a four-line change across two files. | |
| #9 lint spread tests with shellcheck | snapcraft-rocks | closed | Shellcheck linting for spread tests was implemented via merged pull request #14. The issue is closed. | |
| #2381 tools: copy in spread-shellcheck from snapd | snapcraft | merged | Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions. | |
| #14 chore(ci): add shellcheck and yamllint | snapcraft-rocks | merged | Merged. Resolves issue #9 by adding shellcheck and yamllint to the CI pipeline. Approved by one reviewer. Updates 5 files with 49 additions and 7 deletions. | |
| #2172 many: add shellcheck to static tests | snapcraft | merged | Merged into master. Added shellcheck to static tests to validate shell scripts across 28 files. The change passed CI, received reviewer approval, and slightly increased code coverage. | |
| #4720 chore(core24): update package for linter spread test | snapcraft | merged | Merged a one-line package update for a linter spread test to address a time_t compatibility issue. Approved by two reviewers and passed CI checks. | |
| #4022 lint: ignore snapd-testing-tools, venv | snapcraft | merged | Merged linter configuration updates to ignore venv, snapd-testing-tools, and cache directories, resolving local development failures. Approved by reviewers, passed CI, and integrated into main. |