← Back to issue list

lint: add shellcheck and spread-shellcheck linters

View original Github issue

Metadata

Project
rockcraft
Number
#196
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes.

Resolution: closed resolved

Reason: PR #196 was approved and merged as commit b7c4c794, enabling both shell-based linters in the GitHub workflow.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Add new linter for shellcheck and spread-shellcheck to the github workflow. Includes some minor fixes to be shellcheck-compliant.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes.
stealth/space-bunny-alpha — closed resolved Merged PR #196 as b7c4c794, adding shellcheck and spread-shellcheck to CI and including minor shellcheck-compliance fixes.
qwen/qwen3.6-35b-a3b — — Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes adding shellcheck and spread-shellcheck linters to the GitHub workflow, including minor compliance fixes. Author inquired about documenting the shellcheck snap dependency for development.

Update history

No update history recorded yet.

Related work

  • Related To: rockcraft#201 (confidence 90%)

    Follow-up PR #201, merged as c90598eb, expanded ShellCheck coverage to spread.yaml.

Related issues

Issue Project State Summary Similarity
#201 lint: run shellcheck on spread.yaml rockcraft merged Merged PR #201 in commit c90598eb, enabling ShellCheck linting for spread.yaml through a small lint-configuration update.
83%
#9 lint spread tests with shellcheck snapcraft-rocks closed Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14".
79%
#291 lint: add shellcheck, yamllint craft-providers merged Merged PR #291 in commit 68ac1cc, adding shellcheck and yamllint from Starbase to address #287.
79%
#2381 tools: copy in spread-shellcheck from snapd snapcraft merged Merged PR #2381 as cce7842e8, adding snapd's spread-shellcheck tool, expanding ShellCheck coverage to spread tests, and correcting affected glob patterns.
74%
#2172 many: add shellcheck to static tests snapcraft merged Merged PR #2172 via commit 25043ab36, adding ShellCheck to static tests and updating affected scripts across 28 files.
71%