← Back to issue list

build providers: better injection logic

View original Github issue

Metadata

Project
snapcraft
Number
#2196
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged build-provider injection improvements in #2196 as commit d9a477ea5 after approval and conflict resolution; changed 12 files.

Resolution: closed resolved

Reason: PR #2196 was approved and merged as commit d9a477ea5, delivering revised build-provider injection logic across 12 files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged build-provider injection improvements in #2196 as commit d9a477ea5 after approval and conflict resolution; changed 12 files.
stealth/space-bunny-alpha — closed resolved Merged PR #2196 as commit d9a477ea5 after approval and conflict resolution, improving build-provider injection logic across 12 files.
qwen/qwen3.6-35b-a3b — — Merged to master following approval and conflict resolution. Updates build provider injection logic across 12 files (+951/-414 lines). CI passed with 91.85% diff coverage, showing a 0.05% overall decrease.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master after resolving conflicts. Improves dependency injection logic for build providers. Code coverage decreased by 0.05% upon merge, maintaining 91.85% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2717 build providers: inject core18 instead of core snapcraft merged Merged #2717 (commit 5ddf2996e), replacing unversioned core injection with core18 across two build-provider files (+7/−7).
78%
#2508 Build provider errors snapcraft merged Merged PR #2508 in commit 8d8f411b3, enhancing build-provider error handling across two files (+353/-85 lines).
75%
#2515 build providers: support for provider setup snapcraft merged Merged PR #2515 as e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586.
72%
#2621 build providers: support injection for LXD snapcraft merged Merged as d59622a81, adding LXD snap injection through snapd's file API, replacing mount-based injection with file pushes, and refactoring provider concerns.
70%