build providers: better injection logic
Metadata
Current evaluation
Merged to master following approval and conflict resolution. Updates build provider injection logic across 12 files (+951/-414 lines). CI passed with 91.85% diff coverage, showing a 0.05% overall decrease.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to master following approval and conflict resolution. Updates build provider injection logic across 12 files (+951/-414 lines). CI passed with 91.85% diff coverage, showing a 0.05% overall decrease. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master after resolving conflicts. Improves dependency injection logic for build providers. Code coverage decreased by 0.05% upon merge, maintaining 91.85% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master after resolving conflicts. Improved build provider injection logic. Code coverage decreased by 0.06% with 91.85% diff coverage. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2508 Build provider errors | snapcraft | merged | Merged after approval and passing CI checks. Resolved build provider errors across two files (+353/-85 lines). Codecov reported 90.62% diff coverage. | |
| #2717 build providers: inject core18 instead of core | snapcraft | merged | Merged. Updates build providers to inject core18 instead of core. Approved by one reviewer with passing CI checks. Changes modify two files with seven additions and seven deletions. | |
| #2773 build providers: inject snapd snap for latest feature availability | snapcraft | merged | Merged changes that inject the snapd snap into build providers instead of core, improving feature availability and reducing size. Approved by reviewer, passed CI, and modified 4 files (+59/-12 lines). | |
| #2515 build providers: support for provider setup | snapcraft | merged | Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged documentation update to build provider procedures, resolving issue #5519. Approved by two reviewers and passed most CI checks despite minor integration test failures. Changes span four files with 100 lines added and 98 removed. | |
| #2215 provider changes | snapcraft | merged | Merged into master after approval and passing CI. The pull request implements provider changes across one file with a +9/-2 line diff. Codecov reported a negligible coverage decrease. | |
| #2394 build providers: fix osx non base and injection | snapcraft | merged | Merged fix for macOS build provider non-base and injection issues. Approved by one reviewer, passed CI, and updated five files to resolve SNAPCRAFT-78, SNAPCRAFT-7A, and Launchpad bug 1801965. | |
| #2252 build providers: shell in provider if debug is used | snapcraft | merged | Merged changes enabling shell access in build providers during debug sessions. Approved by a reviewer, passed CI, and updated five files with 112 additions and 21 deletions. | |
| #2507 build providers: improve handling in snap logic | snapcraft | merged | Merged. Improved snap provider logic by cleaning up channel warnings, removing unnecessary sudo calls, and silencing noisy refresh hold commands. Approved, passed CI, and modified 5 files (+131/-73 lines). |