build providers: support for provider setup
Metadata
Current evaluation
Merged PR #2515 as e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586.
Resolution: closed resolved
Reason: PR #2515 was approved and merged into master as commit e4a578823, implementing provider-owned setup and checks.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Move checks and setup to the provider implementation.
LP: #1821586
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2515 as e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#2515 as commit e4a578823, moving build-provider checks and setup into provider implementations and resolving LP #1821586. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Moves build provider checks and setup logic directly into provider implementations, addressing LP #1821586. Codecov reported 74.24% diff coverage prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2275 build providers: use the provider if exported | snapcraft | merged | Merged PR #2275, fixing build-provider selection so an exported provider is used. | |
| #2508 Build provider errors | snapcraft | merged | Merged PR #2508 in commit 8d8f411b3, enhancing build-provider error handling across two files (+353/-85 lines). | |
| #3290 build providers: unified provider refactoring for provider setup | snapcraft | closed | Closed unmerged; the proposed unified build-provider setup refactor in #3290 was not adopted. | |
| #9 providers: add build provider support (CRAFT-28) | rockcraft | merged | Merged build-provider support via commit be6dec45, integrating craft-providers to run builds on LXD. User messages and provider log retrieval were deferred to follow-up work. | |
| #2282 build providers: cleaner start and launch messaging | snapcraft | merged | Merged PR #2282 via commit edc4a9f16, improving build-provider startup and instance-launch messaging for LP #1793101. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged PR #2474 as commit 4308dd8d3, removing obsolete build-provider methods left over from legacy cleanbuild support. | |
| #1821586 Improved build provider sanity checks | snapcraft (launchpad) | closed | Resolved by merged snapcraft#2515 (commit e4a578823), moving build-provider setup and sanity checks into provider implementations. | |
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged PR #2374 (commit ec0fbe2be, LP #1792242) adds cleanup so build providers are destroyed when creation/launch fails, preventing VMs from being left running. | |
| #3232 build providers: install apt-transport-https | snapcraft | merged | Merged PR #3232 (commit 409b8e862) installs apt-transport-https during build-provider setup, enabling access to package repositories over HTTPS. | |
| #2196 build providers: better injection logic | snapcraft | merged | Merged build-provider injection improvements in #2196 as commit d9a477ea5 after approval and conflict resolution; changed 12 files. |