build providers: support for provider setup
Metadata
Current evaluation
Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586.
Suggested action: —
No scores available.
Issue body
Move checks and setup to the provider implementation.
LP: #1821586
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Moves build provider checks and setup logic directly into provider implementations, addressing LP #1821586. Codecov reported 74.24% diff coverage prior to merge. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Relocates validation checks and initialization logic to the provider implementation, enabling proper provider setup per LP #1821586. Changes passed review and met coverage thresholds. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2508 Build provider errors | snapcraft | merged | Merged after approval and passing CI checks. Resolved build provider errors across two files (+353/-85 lines). Codecov reported 90.62% diff coverage. | |
| #2275 build providers: use the provider if exported | snapcraft | merged | Merged an update to build provider logic that enables using a provider if it is exported. Approved by a reviewer, passed CI checks, and integrated into the codebase. | |
| #3290 build providers: unified provider refactoring for provider setup | snapcraft | closed | Abandoned and closed without merge. Refactored provider setup by introducing is_provider_ready and consolidating installation logic. No reviews were completed and changes were not integrated. | |
| #5537 docs: update build provider procedures | snapcraft | merged | Merged documentation update to build provider procedures, resolving issue #5519. Approved by two reviewers and passed most CI checks despite minor integration test failures. Changes span four files with 100 lines added and 98 removed. | |
| #2249 build providers: provide support to shell in | snapcraft | merged | Merged. Adds shell access support to build providers, resolving LP #1782775. Approved by reviewer, passed CI checks, and implemented across 8 files. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| #2215 provider changes | snapcraft | merged | Merged into master after approval and passing CI. The pull request implements provider changes across one file with a +9/-2 line diff. Codecov reported a negligible coverage decrease. | |
| #130 fix(test): fix provider integration tests | craft-application | merged | Merged to main. Fixed provider integration tests by modifying one file (+3/-9 lines). Achieved 100% diff coverage with no impact on overall metrics. Approved by two reviewers and passed CI checks prior to merge. | |
| #2196 build providers: better injection logic | snapcraft | merged | Merged to master following approval and conflict resolution. Updates build provider injection logic across 12 files (+951/-414 lines). CI passed with 91.85% diff coverage, showing a 0.05% overall decrease. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. |