← Back to issue list

kbuild plugin: kconfigfile is modified if kconfigs is supplied

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1786083
Type
issue
State
closed
Author
~kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

kbuild plugin modified the source tree's kconfigfile when kconfigs were supplied. Fixed by merged PR snapcore/snapcraft#2204 (commit f156050bf), which copies kconfigfile before applying kconfigs; LP #1786083 closed by maintainer ~kyrofa.

Resolution: closed resolved

Reason: Maintainer kyrofa cited PR snapcore/snapcraft#2204 as the proposed fix; that PR was merged as commit f156050bf ("kbuild plugin: stop modifying kconfigfile"), and the Launchpad bug was closed afterwards. The fix makes the plugin copy kconfigfile into the build dir before applying kconfigs so the source tree is left untouched.

Evaluated by: mr-cal-bot

No scores available.

Issue body

If both kconfigfile and kconfigs is supplied when using the kbuild plugin, the kconfigfile (in the original source tree) is actually modified with the kconfigs. Snapcraft should not modify source code.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved kbuild plugin modified the source tree's kconfigfile when kconfigs were supplied. Fixed by merged PR snapcore/snapcraft#2204 (commit f156050bf), which copies kconfigfile before applying kconfigs; LP #1786083 closed by maintainer ~kyrofa.
stealth/space-bunny-alpha — closed resolved Fixed by merged PR snapcraft#2204 in commit f156050bf: kbuild now copies kconfigfile before applying kconfigs, preventing source-tree modification.
stealth/space-bunny-alpha — closed resolved Fixed by canonical/snapcraft#2204 in commit f156050bf: the kbuild plugin stopped modifying the original kconfigfile.
stealth/space-bunny-alpha — closed resolved Fixed in snapcraft#2204: kbuild now copies kconfigfile instead of hard-linking it, preventing supplied kconfigs from modifying the source tree.
qwen/qwen3.6-35b-a3b — — The kbuild plugin bug modifying the original kconfigfile when kconfigs is supplied was closed without a documented fix, indicating it was abandoned. No patches were merged to resolve the issue.
qwen/qwen3.6-35b-a3b — — Closed without resolution. The kbuild plugin incorrectly modified the source kconfigfile when kconfigs were supplied. No comments or fixes were provided, indicating the issue was abandoned.
qwen/qwen3.6-35b-a3b — — Closed without resolution or comments. The kbuild plugin incorrectly modified the source kconfigfile when kconfigs was supplied, violating source preservation rules.
qwen3.6-35b-a3b-mtp-q6 — — The kbuild plugin incorrectly modifies the original kconfigfile when kconfigs is provided. The report closed without resolution, leaving the bug unfixed.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#2204 (confidence 98%)

    Merged PR 'kbuild: stop modifying kconfigfile' (commit f156050bf) referenced directly in the closing maintainer comment; changes kbuild to copy kconfigfile before applying kconfigs.

  • Related To: canonical/snapcraft#2202 (confidence 55%)

    Nearby kbuild change 'read configs from source directory instead' (commit b6327b0e4) landed in the same area around the same fix, hardening kbuild config handling.

Related issues

Issue Project State Summary Similarity
#2204 kbuild: stop modifying kconfigfile snapcraft merged Merged #2204 (f156050bf), changing kbuild to copy kconfigfile before applying kconfigs, preventing source-tree config modification and fixing LP #1786083.
78%
#2202 plugins: kbuild: read configs from source directory instead snapcraft merged Merged PR #2202 (commit b6327b0e4), making kbuild read kernel configs from the source directory so remote Git trees are handled correctly.
71%