← Back to issue list

kbuild: stop modifying kconfigfile

View original Github issue

Metadata

Project
snapcraft
Number
#2204
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2204 (f156050bf), changing kbuild to copy kconfigfile before applying kconfigs, preventing source-tree config modification and fixing LP #1786083.

Resolution: closed resolved

Reason: The approved PR was merged as commit f156050bf. It replaces the hard link with a copy before applying kconfigs, preventing changes to the original config file.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? ----- If the `kconfigfile` option is supplied, the kbuild plugin uses a hard link to put it into place. This becomes problematic if `kconfigfile` is used alongside `kconfigs`, because doing so modifies the config file, thereby modifying the original `kconfigfile` in the source tree. This PR fixes [LP: #1786083](https://bugs.launchpad.net/snapcraft/+bug/1786083) by copying the `kconfigfile` instead of using hard links.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2204 (f156050bf), changing kbuild to copy kconfigfile before applying kconfigs, preventing source-tree config modification and fixing LP #1786083.
stealth/space-bunny-alpha — closed resolved Merged PR #2204 (commit f156050b) makes the kbuild plugin copy `kconfigfile` instead of hard-linking it, so using it with `kconfigs` no longer modifies the source-tree config. Fixes LP: #1786083.
stealth/space-bunny-alpha — closed resolved Merged PR #2204 made kbuild copy kconfigfile instead of hard-linking it, preventing source-tree modifications. Fixes LP #1786083.
qwen/qwen3.6-35b-a3b — — Merged. The kbuild plugin copies the kconfigfile instead of using hard links, preventing unintended modifications to the source tree when combined with kconfigs. Resolves LP: #1786083.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced hard links with file copying in the kbuild plugin to prevent modifying the original kconfigfile when used with kconfigs, resolving LP: #1786083. Diff coverage reached 100%.

Update history

No update history recorded yet.

Related work

Related issues

Issue Project State Summary Similarity
#1786083 kbuild plugin: kconfigfile is modified if kconfigs is supplied snapcraft (launchpad) closed kbuild plugin modified the source tree's kconfigfile when kconfigs were supplied. Fixed by merged PR snapcore/snapcraft#2204 (commit f156050bf), which copies kconfigfile before applying kconfigs; LP #1786083 closed by maintainer ~kyrofa.
78%