← Back to issue list

plugin: update catkin plugin to support melodic

View original Github issue

Metadata

Project
snapcraft
Number
#2248
Type
pull request
State
closed
Author
NickZ
Labels
—
Created
Updated
Closed

Current evaluation

PR to add Melodic support to the catkin plugin was held pending base support, then closed by kyrofa as superseded by merged PR #2333 (commit a7fb1b137), which made ROS distros base-aware: core16→Kinetic, core18→Melodic, dropping rosdistro.

Resolution: closed superseded

Reason: Maintainer kyrofa commented on 2018-10-09 "Closing in favor of #2333, thanks @NickZ!" after the original change was blocked until base (core18/bionic) support landed. PR #2333, "catkin, catkin-tools: add support for bases", was merged as commit a7fb1b137 and implemented base-driven distro selection (core16 selects Kinetic, core18 selects Melodic, rosdistro option removed).

Evaluated by: mr-cal-bot

No scores available.

Issue body

ROS Melodic uses bionic as a base. I note that I'm required to `stage-packages['libc6']` now using this, which I wasn't before with kinetic, because the GLIBC version of the targeted core was 2.23, and most of the included libraries required 2.27. I'm not sure how to change this. Here's my snapcraft.yaml. I am building on Bionic 18.04.1. https://gist.github.com/NickZ/309fc17d5341c86e35f16a726cf48706

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR to add Melodic support to the catkin plugin was held pending base support, then closed by kyrofa as superseded by merged PR #2333 (commit a7fb1b137), which made ROS distros base-aware: core16→Kinetic, core18→Melodic, dropping rosdistro.
stealth/space-bunny-alpha — closed superseded Superseded by merged PR #2333 (commit a7fb1b137), which added base-aware ROS selection for Kinetic/core16 and Melodic/core18.
qwen/qwen3.6-35b-a3b — — Superseded by PR #2333. The maintainer deferred the merge until full base18 support landed, then closed the request in favor of the newer pull request.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #2333. The Melodic support update was deferred until full base18/Bionic support landed, then closed in favor of the newer pull request.

Update history

No update history recorded yet.

Related work

  • Superseded By: snapcraft#2333 (confidence 97%)

    Merged PR titled 'catkin, catkin-tools: add support for bases' (commit a7fb1b137); the closing maintainer comment explicitly names #2333 as the replacement.

  • Related To: snapcraft#2847 (confidence 35%)

    Later catkin plugin change ('consider only local workspaces', commit 1d476f622) continuing the same plugin's evolution; not the direct fix.

Related issues

Issue Project State Summary Similarity
#2333 catkin, catkin-tools: add support for bases snapcraft merged Merged PR #2333 via commit a7fb1b137, adding base-aware catkin support: core16 selects Kinetic, core18 selects Melodic, and rosdistro is removed.
75%
#1629003 Catkin plugin: support kinetic snapcraft (launchpad) closed ROS Kinetic support was added to the Catkin plugin by snapcore/snapcraft PR #842, merged as commit 5d447aedc; the maintainer closed the issue pointing to that fix.
70%