catkin, catkin-tools: add support for bases
Metadata
Current evaluation
Merged PR #2333 via commit a7fb1b137, adding base-aware catkin support: core16 selects Kinetic, core18 selects Melodic, and rosdistro is removed.
Resolution: closed resolved
Reason: PR #2333 was merged as commit a7fb1b137 after approval. It resolved LP #1794778 and LP #1794779 by updating catkin and catkin-tools to derive the ROS release from the Snapcraft base.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1794778](https://bugs.launchpad.net/snapcraft/+bug/1794778) and [LP: #1794779](https://bugs.launchpad.net/snapcraft/+bug/1794779) by updating the Catkin plugin (and by extension the Catkin Tools plugin) to be base-aware. It removes the `rosdistro` option and uses only the LTS ROS release corresponding to the base being used, specifically Kinetic if core16 and Melodic if core18. Finally, it updates all Catkin Spread tests to use bases except for one legacy test that ensures legacy gets dispatched when no bases are being used.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2333 via commit a7fb1b137, adding base-aware catkin support: core16 selects Kinetic, core18 selects Melodic, and rosdistro is removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2333 in commit a7fb1b137, making catkin and catkin-tools base-aware and selecting ROS Kinetic for core16 or Melodic for core18. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #2333 (commit a7fb1b137): catkin and catkin-tools gained base-aware ROS selection, removing rosdistro and choosing Kinetic/core16 or Melodic/core18. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged update adding base support to catkin and catkin-tools plugins. Replaces rosdistro with automatic ROS release selection per base (Kinetic/core16, Melodic/core18). Resolves Launchpad bugs #1794778 and #1794779. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated catkin and catkin-tools plugins to support bases, replacing the rosdistro option with automatic ROS version selection based on the target base. Resolved LP #1794778 and #1794779. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794779 Update the catkin-tools plugin to be base aware | snapcraft (launchpad) | closed | Catkin and catkin-tools plugins gained base-aware support in PR #2333 (commit a7fb1b137). | |
| #2248 plugin: update catkin plugin to support melodic | snapcraft | closed | PR to add Melodic support to the catkin plugin was held pending base support, then closed by kyrofa as superseded by merged PR #2333 (commit a7fb1b137), which made ROS distros base-aware: core16→Kinetic, core18→Melodic, dropping rosdistro. | |
| #1794778 Update the catkin plugin to be base aware | snapcraft (launchpad) | closed | Base-aware catkin and catkin-tools support was merged in snapcraft#2333, commit a7fb1b137. | |
| #842 Catkin plugin: Support ROS Kinetic. | snapcraft | merged | Merged as commit 5d447aedc, adding ROS Kinetic support to the catkin plugin by refactoring repository source handling into an overridable function and adding a ROS-release-to-Ubuntu-release map (fixes LP #1629003). | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged #152 as fc5142126, adding ROS package installation, roslaunch/rosrun support, updated examples, and doubled Catkin test coverage. | |
| #1629003 Catkin plugin: support kinetic | snapcraft (launchpad) | closed | ROS Kinetic support was added to the Catkin plugin by snapcore/snapcraft PR #842, merged as commit 5d447aedc; the maintainer closed the issue pointing to that fix. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged #2363, adding base-aware support for the Make plugin and inherited CMake and Autotools plugins for core16/core18; commit 2f3879d93. | |
| #1593 catkin tools plugin: add catkin tools support. | snapcraft | merged | Merged PR #1593 (commit 7e31fa0dd), adding a beta catkin-tools plugin that uses catkin tools for builds while retaining catkin_make behavior. |