catkin, catkin-tools: add support for bases
Metadata
Current evaluation
Merged update adding base support to catkin and catkin-tools plugins. Replaces rosdistro with automatic ROS release selection per base (Kinetic/core16, Melodic/core18). Resolves Launchpad bugs #1794778 and #1794779. Approved and merged.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This PR resolves [LP: #1794778](https://bugs.launchpad.net/snapcraft/+bug/1794778) and [LP: #1794779](https://bugs.launchpad.net/snapcraft/+bug/1794779) by updating the Catkin plugin (and by extension the Catkin Tools plugin) to be base-aware. It removes the `rosdistro` option and uses only the LTS ROS release corresponding to the base being used, specifically Kinetic if core16 and Melodic if core18. Finally, it updates all Catkin Spread tests to use bases except for one legacy test that ensures legacy gets dispatched when no bases are being used.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged update adding base support to catkin and catkin-tools plugins. Replaces rosdistro with automatic ROS release selection per base (Kinetic/core16, Melodic/core18). Resolves Launchpad bugs #1794778 and #1794779. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updated catkin and catkin-tools plugins to support bases, replacing the rosdistro option with automatic ROS version selection based on the target base. Resolved LP #1794778 and #1794779. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates Catkin and Catkin Tools plugins to be base-aware, removing the rosdistro option and mapping bases to ROS releases (Kinetic/core16, Melodic/core18). Resolves Launchpad bugs #1794778 and #1794779. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #842 Catkin plugin: Support ROS Kinetic. | snapcraft | merged | Merged. Adds ROS Kinetic support to the Catkin plugin by refactoring source handling for extensibility and mapping ROS to Ubuntu releases. Fixed a fileutils coverage gap during review. Approved and merged. | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled. | |
| #1367 catkin plugin: add support for ROS Lunar | snapcraft | merged | Merged the catkin plugin update to support ROS Lunar alongside Indigo, Jade, and Kinetic. CI initially failed due to a Launchpad bug, resolved by adding lsb-release to build-packages. Approved and merged after passing integration tests. | |
| #2363 {make,cmake,autotools} plugin: add support for bases | snapcraft | merged | Merged update adds base support (core16, core18) to Make, CMake, and Autotools plugins, resolving three Launchpad bugs. Make plugin tests moved to Spread. Approved, passed CI, and achieved 100% diff coverage. | |
| #1581 catkin plugin: support rosdep pip dependencies | snapcraft | merged | Merged implementation adding pip-based dependency support to the Catkin plugin's rosdep resolver, resolving Launchpad bug #1683036. Approved by one reviewer, passed CI, and modified 12 files. | |
| #180 Backport to 1.x: Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged backport of #152 to the 1.x branch, adding ROS tool support to the Catkin plugin. The update modified four files with 112 additions and 28 deletions, successfully integrating the feature. | |
| #1794779 Update the catkin-tools plugin to be base aware | snapcraft (launchpad) | closed | Closed without implementation or discussion. The request was abandoned, likely superseded by newer base-aware tooling given the EOL status of the 18.10 build environment. |