← Back to issue list

build-providers: add support for --shell-after

View original Github issue

Metadata

Project
snapcraft
Number
#2253
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged pull request adding --shell-after support to build-providers. Approved by one reviewer with 100% diff coverage. Changes span 3 files, adding 87 lines and removing 6.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged pull request adding --shell-after support to build-providers. Approved by one reviewer with 100% diff coverage. Changes span 3 files, adding 87 lines and removing 6.
qwen3.6-35b-a3b-mtp-q6 Merged implementation adding --shell-after support to build-providers. Authored by maintainer sergiusens, the feature was integrated into the main branch with 100% diff coverage verified by Codecov.
qwen3.6-35b-a3b-mtp-q6 Merged into master, adding --shell-after support to build-providers. The change passed all unit and static tests, achieved 100% diff coverage, and was successfully integrated into the codebase.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2254 build providers: add support for --shell snapcraft merged Merged after approval by two reviewers. Adds --shell support to build providers across three files. Passed all unit and static tests with 100% diff coverage.
88%
#2249 build providers: provide support to shell in snapcraft merged Merged. Adds shell access support to build providers, resolving LP #1782775. Approved by reviewer, passed CI checks, and implemented across 8 files.
80%
#2252 build providers: shell in provider if debug is used snapcraft merged Merged changes enabling shell access in build providers during debug sessions. Approved by a reviewer, passed CI, and updated five files with 112 additions and 21 deletions.
77%