build-providers: add support for --shell-after
Metadata
Current evaluation
Merged as 21cfd4750, adding build-provider support for --shell-after so a shell can open after the requested lifecycle step.
Resolution: closed resolved
Reason: PR #2253 was merged into Snapcraft by commit 21cfd4750. The implementation forwards --shell-after through the provider lifecycle and launches the shell after processing.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as 21cfd4750, adding build-provider support for --shell-after so a shell can open after the requested lifecycle step. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged build-provider support for --shell-after with 100% diff coverage; landed as commit 21cfd4750 via #2253. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2253, adding build-provider support for --shell-after in commit 21cfd4750. The change was maintainer-approved and had 100% diff coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request adding --shell-after support to build-providers. Approved by one reviewer with 100% diff coverage. Changes span 3 files, adding 87 lines and removing 6. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged implementation adding --shell-after support to build-providers. Authored by maintainer sergiusens, the feature was integrated into the main branch with 100% diff coverage verified by Codecov. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2254 build providers: add support for --shell | snapcraft | merged | Merged PR #2254 added --shell support for build providers in commit a24d398e4; companion --shell-after support landed in #2253. | |
| #1782768 Add --shell for lifecycle steps | snapcraft (launchpad) | closed | Feature request closed by the author's own pointer to snapcraft PR #2254, which added --shell support to build providers (commit a24d398e4); companion --shell-after landed in PR #2253. | |
| #1782767 Add --shell-after for lifecycle steps | snapcraft (launchpad) | closed | Implemented --shell-after via merged snapcore/snapcraft PR #2253 (commit 21cfd4750), opening a shell after the selected lifecycle step. | |
| #68 commands: add shell and shell after parameters | rockcraft | merged | Merged #68 in commit c0aa75c1, adding --shell and --shell-after to open interactive shells in the build instance during parts lifecycle execution. | |
| #2252 build providers: shell in provider if debug is used | snapcraft | merged | Merged PR #2252 (commit 3410ec32d) added a shell inside build providers for debug runs, with related test updates. |