build providers: add support for --shell
Metadata
Current evaluation
Merged PR #2254 added --shell support for build providers in commit a24d398e4; companion --shell-after support landed in #2253.
Resolution: closed resolved
Reason: PR #2254 was merged into master as commit a24d398e4, implementing and testing build-provider shell access with --shell.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2254 added --shell support for build providers in commit a24d398e4; companion --shell-after support landed in #2253. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #2254 by sergiusens merged (commit a24d398e4), adding --shell support to build providers; landed after the related #2249, #2252, #2253 series. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged build-provider support for `--shell` in PR #2254, resolving the feature in commit a24d398e4. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers. Adds --shell support to build providers across three files. Passed all unit and static tests with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added --shell support to build providers. Tests passed with 100% diff coverage. Maintainer confirmed success after a Travis CI connectivity delay prevented automatic status updates. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#2253
(confidence 98%)
Its immediately preceding commit added --shell-after support, complementing --shell.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2253 build-providers: add support for --shell-after | snapcraft | merged | Merged as 21cfd4750, adding build-provider support for --shell-after so a shell can open after the requested lifecycle step. | |
| #2252 build providers: shell in provider if debug is used | snapcraft | merged | Merged PR #2252 (commit 3410ec32d) added a shell inside build providers for debug runs, with related test updates. | |
| #1782768 Add --shell for lifecycle steps | snapcraft (launchpad) | closed | Feature request closed by the author's own pointer to snapcraft PR #2254, which added --shell support to build providers (commit a24d398e4); companion --shell-after landed in PR #2253. | |
| #2249 build providers: provide support to shell in | snapcraft | merged | Merged PR #2249 (commit 9f5640b17) adding a shell() method to snapcraft build providers, enabling interactive 'shell into' the Multipass/LXD build instance. | |
| #68 commands: add shell and shell after parameters | rockcraft | merged | Merged #68 in commit c0aa75c1, adding --shell and --shell-after to open interactive shells in the build instance during parts lifecycle execution. |