build providers: add support for --shell
Metadata
Current evaluation
Merged after approval by two reviewers. Adds --shell support to build providers across three files. Passed all unit and static tests with 100% diff coverage.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval by two reviewers. Adds --shell support to build providers across three files. Passed all unit and static tests with 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Added --shell support to build providers. Tests passed with 100% diff coverage. Maintainer confirmed success after a Travis CI connectivity delay prevented automatic status updates. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Added --shell support to build providers. The pull request merged after passing all unit and static tests with 100% diff coverage. A Travis CI disconnect issue was resolved by the maintainer prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2253 build-providers: add support for --shell-after | snapcraft | merged | Merged pull request adding --shell-after support to build-providers. Approved by one reviewer with 100% diff coverage. Changes span 3 files, adding 87 lines and removing 6. | |
| #2249 build providers: provide support to shell in | snapcraft | merged | Merged. Adds shell access support to build providers, resolving LP #1782775. Approved by reviewer, passed CI checks, and implemented across 8 files. | |
| #2252 build providers: shell in provider if debug is used | snapcraft | merged | Merged changes enabling shell access in build providers during debug sessions. Approved by a reviewer, passed CI, and updated five files with 112 additions and 21 deletions. | |
| #2275 build providers: use the provider if exported | snapcraft | merged | Merged an update to build provider logic that enables using a provider if it is exported. Approved by a reviewer, passed CI checks, and integrated into the codebase. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). |