schema: add "legacy" adapter type
Metadata
Current evaluation
Merged PR #2262 as 66c0cd0dd, adding the default "legacy" app adapter to preserve wrapper generation and resolve LP #1792018.
Resolution: closed resolved
Reason: PR #2262 was approved and merged as commit 66c0cd0dd. It made the legacy adapter the compatibility default while retaining generated wrappers.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently, the snapcraft CLI supports app adapters which can either not be set, or set to "none". If set to "none", no wrappers are generated for that app. If unset, wrappers are generated.
This PR resolves [LP: #1792018](https://bugs.launchpad.net/snapcraft/+bug/1792018) by changing this to default to using a new "legacy" adapter type, which generates wrappers. This leads nicely to having a "full" adapter for using the command-chain, which will be coming soon.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2262 as 66c0cd0dd, adding the default "legacy" app adapter to preserve wrapper generation and resolve LP #1792018. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#2262 (66c0cd0dd): added the default "legacy" adapter, preserving wrapper generation and resolving LP #1792018. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2262 added a "legacy" schema adapter that preserves wrapper generation, resolving LP #1792018 in commit 66c0cd0dd. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged request adding a legacy adapter type to the schema. Changes default app adapter behavior to generate wrappers, resolving LP: #1792018. Approved by one reviewer, passed CI, and modified four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged addition of a "legacy" adapter type to the schema. Defaults wrapper generation to the legacy adapter, resolving Launchpad bug #1792018. Authored by maintainer kyrofa and passed all tests. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2343
(confidence 98%)
Follow-up PR #2343, merged as d99c1fe43, added the promised full command-chain adapter.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1792018 Add "legacy" adapter type | snapcraft (launchpad) | closed | Added the "legacy" app adapter via snapcore/snapcraft PR #2262, commit 66c0cd0dd. | |
| #1860873 Regression: No difference between "legacy" and "full" app adapter | snapcraft (launchpad) | closed | Snapcraft's automatic wrapper/command-chain handling made adapter obsolete; merged PR #3741 (commit 46a3e90be) deprecated it. The legacy/full distinction was ultimately removed, not restored. | |
| #2343 schema, meta: add "full" app adapter | snapcraft | merged | Merged PR #2343 (commit d99c1fe43), adding the full app adapter via snapd command-chain instead of wrappers; legacy remained the default for compatibility. | |
| #1420 add new "no-wrapper" property to apps | snapcraft | merged | Merged PR #1420 redesigned app wrappers: `adapter: none` replaced the proposed `no-wrapper` property, resolving LP bug #1706575. |