← Back to issue list

schema, meta: add "full" app adapter

View original Github issue

Metadata

Project
snapcraft
Number
#2343
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2343 (commit d99c1fe43), adding the full app adapter via snapd command-chain instead of wrappers; legacy remained the default for compatibility.

Resolution: closed resolved

Reason: PR #2343 was merged as commit d99c1fe43 and states that it resolves LP #1794532. It added full adapter support while retaining legacy as the default pending snapd 2.36.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- Today, the snapcraft CLI supports both "none" and "legacy" as app adapters, "none" meaning no wrappers or environment at all, and "legacy" meaning wrappers. This PR resolves [LP: #1794532](https://bugs.launchpad.net/snapcraft/+bug/1794532) by adding a "full" app adapter that means no more wrappers, but fully utilizes snap'd command-chain to accomplish the same thing in a much nicer way. This requires snapd 2.36 which is not yet released, so continue using "legacy" as the default for now.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2343 (commit d99c1fe43), adding the full app adapter via snapd command-chain instead of wrappers; legacy remained the default for compatibility.
stealth/space-bunny-alpha — closed resolved Merged PR #2343 (commit d99c1fe43) adds a "full" app adapter for snapcraft that uses snapd command-chain instead of legacy wrappers; "legacy" stays the default until snapd 2.36.
stealth/space-bunny-alpha — closed resolved Merged PR #2343 (commit d99c1fe43) adds a "full" app adapter that replaces legacy wrappers with snapd command-chain; "legacy" stays the default pending snapd 2.36. Follow-ups: #2375, #2379.
stealth/space-bunny-alpha — closed resolved Merged PR #2343, commit d99c1fe43, added the full app adapter using snapd command-chain instead of wrappers; legacy remains the default for compatibility.
qwen/qwen3.6-35b-a3b — — Merged addition of a full app adapter to snapcraft. Replaces wrapper-based execution with snapd 2.36+ command-chain, resolving LP 1794532. The legacy adapter remains the default for compatibility.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Adds a "full" app adapter using snapd command-chain instead of legacy wrappers, resolving LP: #1794532. Requires snapd 2.36; "legacy" remains default.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1794532 (confidence 100%)

    The PR explicitly identifies this Launchpad bug as resolved by the full adapter implementation.

Related issues

Issue Project State Summary Similarity
#1794532 Add "full" adapter type snapcraft (launchpad) closed Full adapter merged in canonical/snapcraft#2343 (d99c1fe43), using snapd command-chain without wrappers; legacy remained the default for compatibility.
85%
#1860873 Regression: No difference between "legacy" and "full" app adapter snapcraft (launchpad) closed Snapcraft's automatic wrapper/command-chain handling made adapter obsolete; merged PR #3741 (commit 46a3e90be) deprecated it. The legacy/full distinction was ultimately removed, not restored.
79%
#1792018 Add "legacy" adapter type snapcraft (launchpad) closed Added the "legacy" app adapter via snapcore/snapcraft PR #2262, commit 66c0cd0dd.
72%
#2379 meta: add assumes if using "full" app adapter snapcraft merged Merged as commit 2b5a254ef, adding assumes: [command-chain] when the full app adapter is used, resolving LP #1799295.
72%
#1799295 Snapcraft should add an "assumes" if full adapter is used snapcraft (launchpad) closed Fixed by snapcraft PR #2379 ("meta: add assumes if using 'full' app adapter"), merged as commit 2b5a254ef; Snapcraft now adds assumes: [command-chain] when the full adapter is used. Maintainer ~kyrofa closed LP #1799295 citing that PR.
71%
#2262 schema: add "legacy" adapter type snapcraft merged Merged PR #2262 as 66c0cd0dd, adding the default "legacy" app adapter to preserve wrapper generation and resolve LP #1792018.
71%
#2853 meta: do not set snapcraft-runner when adapter is "none" snapcraft merged Merged PR #2853 fixed app metadata handling so adapter: none does not add snapcraft-runner to command-chain; full and legacy adapters still do (commit 9599497fb).
70%