build providers: cleaner start and launch messaging
Metadata
Current evaluation
Merged changes that clean up start and launch messaging for build providers. Approved by one reviewer, passed CI checks, and modified eight files to address Launchpad issue #1793101.
Suggested action: —
No scores available.
Issue body
LP: #1793101
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that clean up start and launch messaging for build providers. Approved by one reviewer, passed CI checks, and modified eight files to address Launchpad issue #1793101. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. The pull request refines start and launch messaging for build providers, resolving Launchpad bug #1793101. It passed code coverage checks at 94.11% diff coverage and was integrated by the maintainer author. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to build provider start and launch messaging. Authored by maintainer sergiusens to address Launchpad bug #1793101, the changes passed tests with 94.11% diff coverage and were integrated into the main branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2374 build providers: destroy on create failures | snapcraft | merged | Merged. Resolves a bug where build providers and VMs remained running after launch failures. Adds cleanup logic and tests across seven files, approved by a reviewer and passing CI checks. | |
| #2474 build providers: remove dead code | snapcraft | merged | Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines). | |
| #3284 build providers: rename clean() -> clean_parts() to clarify scope | snapcraft | merged | Merged into master. Renames build provider clean() to clean_parts() to clarify scope, as cleanup extends beyond parts. Approved by one reviewer with 100% diff coverage and zero unresolved comments. | |
| #2284 build providers: make use of time for multipass stop | snapcraft | merged | Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files. | |
| #219 fix: add launchpad build types and states | craft-application | merged | Merged a maintainer fix adding launchpad build types and states. The two-line change in one file passed CI and received approval from two reviewers before integration. | |
| #2515 build providers: support for provider setup | snapcraft | merged | Merged after approval and passing CI. Implemented provider setup support by relocating checks and initialization logic into provider implementations. Modified ten files (+212/-121 lines) and resolves LP #1821586. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. | |
| #364 fix: ensure provider is available before launching | craft-application | merged | Merged a fix by maintainer cmatsuoka ensuring the provider is available before launch. Approved by three reviewers and passed CI. The two-line change in one file resolves potential launch failures caused by missing providers. |