← Back to issue list

build providers: make use of time for multipass stop

View original Github issue

Metadata

Project
snapcraft
Number
#2284
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files.

Suggested action:

No scores available.

Issue body

LP: #1793288 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updates build providers to use time for the multipass stop operation, resolving Launchpad bug #1793288. Codecov reported 66.66% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Updates build providers to use time parameters for stopping Multipass instances, resolving Launchpad bug #1793288. Codecov reported 66.66% diff coverage despite missing base commit uploads.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2869 build providers: use multipass from stable snapcraft merged Merged update to consume Multipass 1.0 from the stable channel for build providers. Approved by one reviewer, modifying four files with minimal changes.
78%
#2288 build providers: use multipass automatically when on darwin snapcraft merged Merged. Automatically enables multipass as the build provider on macOS (darwin). Approved by a reviewer, passed CI checks, and successfully integrated.
73%
#2511 build providers: modify the _run signature snapcraft merged Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks.
73%
#2447 build providers: remove SIGUSR1 signal ignore workaround for multipass snapcraft merged Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval.
72%
#2282 build providers: cleaner start and launch messaging snapcraft merged Merged changes that clean up start and launch messaging for build providers. Approved by one reviewer, passed CI checks, and modified eight files to address Launchpad issue #1793101.
72%
#2961 build providers: remove over use of -i in sudo snapcraft merged Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files.
71%