build providers: make use of time for multipass stop
Metadata
Current evaluation
PR #2284 by sergiusens merged as commit fd476a4e8, fixing LP #1793288: build providers now apply a timeout ('time') to `multipass stop` so instance cleanup no longer hangs.
Resolution: closed resolved
Reason: The PR itself was the resolution: it was merged into snapcraft master as commit fd476a4e8 ("build providers: make use of time for multipass stop (#2284)"), wrapping the multipass stop call in the providers' existing timeout helper and adding tests, addressing LP bug #1793288.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1793288
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2284 by sergiusens merged as commit fd476a4e8, fixing LP #1793288: build providers now apply a timeout ('time') to `multipass stop` so instance cleanup no longer hangs. | |
| stealth/space-bunny-alpha | — | closed resolved | Multipass stop operations in build providers now use time, addressing LP #1793288. PR #2284 merged as commit fd476a4e8. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates build providers to use time for the multipass stop operation, resolving Launchpad bug #1793288. Codecov reported 66.66% diff coverage. |
Update history
No update history recorded yet.
Related work
-
Related To:
LP:#1793288
(confidence 70%)
Upstream Launchpad bug referenced in the PR description as the motivating defect.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1793288 delayed stop for multipass | snapcraft (launchpad) | closed | Multipass stop delays were fixed by merged PR snapcraft#2284 (commit fd476a4e8), adding the --time argument so instance cleanup cannot hang. | |
| #2511 build providers: modify the _run signature | snapcraft | merged | Merged PR #2511 (commit 46e3d1702) by maintainer sergiusens: extended build provider _run() to return command output and refactored the Multipass provider to wrap execute() instead of calling it directly. |