← Back to issue list

pluginhandler: update build should overwrite organize

View original Github issue

Metadata

Project
snapcraft
Number
#2290
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged changes resolve LP: #1794083 by allowing organize to overwrite previously organized files when a part build step updates. Approved by one reviewer, passed CI, and achieved 100% diff coverage.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- If a part uses the `organize` keyword, in order for the `build` step to be updated, the organization must support happening twice without a clean. This PR resolves [LP: #1794083](https://bugs.launchpad.net/snapcraft/+bug/1794083) by adding the ability for `organize` to overwrite files and directories previously organized by the part.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes resolve LP: #1794083 by allowing organize to overwrite previously organized files when a part build step updates. Approved by one reviewer, passed CI, and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve Launchpad bug #1794083. Updates pluginhandler to allow organize to overwrite previously organized files during incremental builds without a clean step. Achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged PR updates the pluginhandler to allow the update build step to overwrite previously organized files, resolving LP: #1794083. The change enables organize to apply twice without a clean build, achieving 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2305 [legacy] pluginhandler: update build should overwrite organize snapcraft merged Merged backport of PR #2290 to the legacy branch, resolving bug LP: #1794083. The update build process now overwrites organize directives. Approved by one reviewer, passed CI, and modified three files.
82%
#2047 pluginhandler: organize in build instead of stage snapcraft merged Merged. Relocates file organization from the stage step to the build step in Snapcraft, resolving double-staging failures and ensuring collision detection accounts for organized files. Approved by reviewer.
78%
#2034 pluginhandler: organize correcly for targets with leading / snapcraft merged Merged fix for #1974 that strips leading slashes from organize keyword targets, ensuring correct os.path.join behavior for destination directories. Approved and passed CI.
72%