← Back to issue list

[legacy] pluginhandler: update build should overwrite organize

View original Github issue

Metadata

Project
snapcraft
Number
#2305
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged legacy backport PR #2305 of #2290, fixing LP #1794083 so update builds can overwrite files arranged by organize.

Resolution: closed resolved

Reason: PR #2305 was merged after approval. It backported merged PR #2290, whose resolving commit 2cef6c3f6 enabled overwrite behavior during incremental builds.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR is a backport of #2290, fixing [LP: #1794083](https://bugs.launchpad.net/snapcraft/+bug/1794083) for legacy.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged legacy backport PR #2305 of #2290, fixing LP #1794083 so update builds can overwrite files arranged by organize.
stealth/space-bunny-alpha — closed resolved Merged legacy backport #2305 of #2290 (commit 2cef6c3f6), fixing LP #1794083 so update builds overwrite files already arranged by organize.
stealth/space-bunny-alpha — closed resolved Merged legacy backport #2305 of #2290 (commit 2cef6c3f6), fixing LP #1794083 by letting update builds overwrite files arranged by organize.
stealth/space-bunny-alpha — closed resolved Merged a legacy backport of #2290, fixing LP #1794083 by allowing update builds to overwrite files arranged by organize.
qwen/qwen3.6-35b-a3b — — Merged backport of PR #2290 to the legacy branch, resolving bug LP: #1794083. The update build process now overwrites organize directives. Approved by one reviewer, passed CI, and modified three files.
qwen3.6-35b-a3b-mtp-q6 — — Merged as a backport of #2290 to resolve LP: #1794083 in the legacy branch. The update build step now correctly overwrites the organize directive in pluginhandler.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#2290 (confidence 100%)

    Original mainline implementation that PR #2305 explicitly backported to legacy.

Related issues

Issue Project State Summary Similarity
#2290 pluginhandler: update build should overwrite organize snapcraft merged Merged PR #2290 at commit 2cef6c3f6 made organize overwrite previously organized files and directories, allowing build updates without cleaning and resolving LP #1794083.
84%
#2047 pluginhandler: organize in build instead of stage snapcraft merged Merged PR #2047 moved organize handling from stage to build, fixing repeat staging and ensuring collision detection sees organized files.
72%