snap: workaround the dirty tree
Metadata
Current evaluation
Merged as commit 089629e17, removing --dirty from git-describe to work around LP #1662388.
Resolution: closed resolved
Reason: The approved change was merged to master as commit 089629e17, applying the git-describe workaround.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Remove --dirty from git-describe to workaround LP: #1662388
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 089629e17, removing --dirty from git-describe to work around LP #1662388. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2294 via commit 089629e17 by sergiusens; dropped --dirty from git-describe in the snap packaging build to work around Launchpad bug #1662388 (2-line change, approved). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2294 via commit 089629e17, removing --dirty from git-describe to work around Launchpad bug #1662388. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after passing CI and receiving two approvals. Removes the --dirty flag from git-describe to workaround Launchpad bug #1662388, resolving dirty tree detection issues during snap builds. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change removing the --dirty flag from git-describe to work around Launchpad bug #1662388. The fix was authored by sergiusens, passed unit tests, and successfully integrated into the master branch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2289 local source: only filter out snapcraft artifacts | snapcraft | closed | Closed unmerged; #2294 superseded its approach with commit 089629e17, removing --dirty from git describe to work around LP #1662388. |