local source: only filter out snapcraft artifacts
Metadata
Current evaluation
Closed unmerged; #2294 superseded its approach with commit 089629e17, removing --dirty from git describe to work around LP #1662388.
Resolution: closed superseded
Reason: A reviewer rejected the change because it could force larger projects to rebuild without cleaning. Merged PR snapcraft#2294 addressed the same bug in commit 089629e17 by removing --dirty from git describe.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Currently, the local source filters out essentially everything related to the snapcraft CLI, including the entire `snap/` directory. However, this is over-zealous: the `snap/` directory and its contents are often committed to version control, and the process of filtering them out makes changes as far as version control is concerned, resulting in a dirty tree. This really becomes problematic if one then uses `git describe --dirty` to determine the version: it's always dirty.
This PR fixes [LP: #1662388](https://bugs.launchpad.net/snapcraft/+bug/1662388) by taking a more fine-grained approach to filtering out files related to the snapcraft CLI: only filter artifacts, i.e. things generated by the snapcraft CLI. This includes `parts/` `stage/`, `prime/` and `snap/.snapcraft/`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; #2294 superseded its approach with commit 089629e17, removing --dirty from git describe to work around LP #1662388. | |
| stealth/space-bunny-alpha | — | closed stale | Closed unmerged after a reviewer rejected the rebuilding-without-cleaning tradeoff. For the same LP #1662388, merged #2294 (089629e17) instead removed --dirty from git describe. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after rejection over rebuilding without cleaning. LP #1662388 instead received a narrower workaround in merged #2294 (089629e17), removing --dirty from git describe. | |
| stealth/space-bunny-alpha | — | closed not a bug | Closed unmerged after a reviewer rejected narrower local-source filtering because rebuilding without cleaning could burden large projects. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. A reviewer rejected the change due to concerns about rebuilding behavior without cleaning, leaving the local source filtering adjustment unresolved. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Rejected and closed without merging. Reviewer opposition cited potential rebuild overhead for larger projects, leading to rejection of the proposed artifact filtering changes. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
snapcraft#2294
(confidence 99%)
Merged workaround for the same Launchpad bug using a narrower change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2256 local source: don't include .snapcraft directory | snapcraft | merged | Merged #2256 (commit abbc92427), fixing LP #1791773 by excluding .snapcraft from local-source copies and stale-part checks. | |
| #1768668 node project labeled as -dirty | snapcraft (launchpad) | closed | Snapcraft stopped producing “-dirty” versions after source-management fixes; the reporter confirmed the behavior was gone, but no exact fixing PR was recorded. | |
| #2294 snap: workaround the dirty tree | snapcraft | merged | Merged as commit 089629e17, removing --dirty from git-describe to work around LP #1662388. |