Fix catkin plugin python calls
Metadata
Current evaluation
PR #230 was closed unmerged after a shebang mistake; PR #232 (kyrofa) superseded it and merged as fe9ca74c9 (31b745f28), using the snap's Python via /usr/bin/env and PATH in 10.ros.sh.
Resolution: closed superseded
Reason: sergiusens closed #230 explicitly so it would not merge after kyrofa pointed out 10.ros.sh has no shebang; kyrofa's replacement PR #232 was merged in commit fe9ca74c9 (squashed as 31b745f28) fixing LP: #1533297 by using in-snap Python.
Evaluated by: mr-cal-bot
No scores available.
Issue body
10.ros.sh which is sourced with setup.sh has a hardcoded
/usr/bin/python which needs to adapt to use the snaps
python interpreter.
LP: #1533297
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #230 was closed unmerged after a shebang mistake; PR #232 (kyrofa) superseded it and merged as fe9ca74c9 (31b745f28), using the snap's Python via /usr/bin/env and PATH in 10.ros.sh. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; canonical/snapcraft#232 superseded it and merged as fe9ca74c9, using the snap's Python for Catkin plugin calls. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after 10.ros.sh was found to lack a shebang; the same in-snap Python fix was subsequently merged in canonical/snapcraft#232. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and abandoned by author to prevent accidental merge. Awaiting further review and a complete fix for the catkin plugin Python interpreter path and a related executable lookup issue. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Abandoned without merging. The author closed the pull request to prevent accidental integration, deferring the hardcoded Python interpreter fix in 10.ros.sh to the reviewer after identifying runtime errors and clarifying the file structure. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#232
(confidence 97%)
kyrofa's rewrite of the fix; merged as fe9ca74c9 (31b745f28) using /usr/bin/env shebangs and PATH-resolved python in 10.ros.sh
-
Related To:
canonical/snapcraft#2007
(confidence 80%)
Later commit 7ac261967 'catkin plugin: replace python calls in all profile.d scripts' continued the same cleanup
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #232 Catkin plugin: Use in-snap python instead of OS-provided. | snapcraft | merged | Merged PR #232 (fe9ca74c9), fixing Catkin on Xenial by using /usr/bin/env Python shebangs and PATH-resolved Python in 10.ros.sh. | |
| #1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages | snapcraft (launchpad) | closed | Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug. |