← Back to issue list

Catkin plugin: Use in-snap python instead of OS-provided.

View original Github issue

Metadata

Project
snapcraft
Number
#232
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for the Catkin plugin failing on Ubuntu Xenial due to removed OS Python 2. Shebangs now use /usr/bin/env python and 10.ros.sh uses path-based Python, resolving review-flagged file conflicts and missing attributes.

Suggested action:

No scores available.

Issue body

This works pre-Xenial since python2 is provided on the image. However, it's been removed in Xenial which uncovered this bug. The fix simply rewrites all /usr/bin/python shebangs to use /usr/bin/env python, and also fixes up 10.ros.sh to use python from the path instead of /usr/bin/python. LP: [#1533297](https://bugs.launchpad.net/snapcraft/+bug/1533297)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for the Catkin plugin failing on Ubuntu Xenial due to removed OS Python 2. Shebangs now use /usr/bin/env python and 10.ros.sh uses path-based Python, resolving review-flagged file conflicts and missing attributes.
qwen3.6-35b-a3b-mtp-q6 Merged. Updated the catkin plugin to use in-snap Python, fixing Ubuntu Xenial compatibility. Resolved reviewer-reported attribute errors and inter-part file conflicts during review before final merge.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes catkin plugin for Ubuntu Xenial by using in-snap Python. Rewrites shebangs to /usr/bin/env python and updates 10.ros.sh. Addressed reviewer feedback on missing attributes and file conflicts.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2007 catkin plugin: replace python calls in all profile.d scripts snapcraft merged Merged update to the catkin plugin replacing absolute Python paths with python in all etc/catkin/profile.d scripts. Fixes broken ROS Kinetic snaps on Ubuntu Core after upstream changes and resolves Catkin Tools plugin issues.
77%
#840 Catkin plugin: build with in-snap python. snapcraft merged Merged after approval. Resolves LP #1628990 by configuring the catkin plugin to use in-snap Python for both build and run times. Adds gcc, libc-dev, and make as build dependencies.
75%
#152 Catkin plugin: Add support for ROS tools. snapcraft merged Merged Catkin plugin updates to properly install ROS packages, include non-source files, and enable ROS tools via an updated wrapper environment. Resolved an xml2-config conflict while planning to remove the redundant roscore plugin. Tests doubled.
74%
#842 Catkin plugin: Support ROS Kinetic. snapcraft merged Merged. Adds ROS Kinetic support to the Catkin plugin by refactoring source handling for extensibility and mapping ROS to Ubuntu releases. Fixed a fileutils coverage gap during review. Approved and merged.
71%
#881 Catkin plugin: Python nodes require gcc/g++ too. snapcraft merged Merged a fix for Launchpad bug #1638317 updating the Catkin plugin to unconditionally stage gcc and g++ at the beginning. This ensures Python nodes compile correctly regardless of roscpp dependencies. The change modifies two files.
70%
#1823788 Catkin plugin doesn't notice ROS dependencies satisfied by stage-snaps snapcraft (launchpad) closed Closed without resolution. The Catkin plugin limitation regarding stage-snap ROS dependencies was abandoned, with no fix implemented.
70%