[WIP] plugins: remove implicit source
Metadata
Current evaluation
WIP PR never merged; closed unmerged. The implicit-source removal it started landed via snapcraft#2326, merged as commit 42c7820ef, implementing LP #1776807.
Resolution: closed superseded
Reason: The PR was abandoned in WIP form after kyrofa noted in the last comment (2018-09-27) that only the tests still needed work. The same change (plugins: remove implicit source) was completed and merged as snapcraft#2326 in commit 42c7820ef with revised internal logic.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
[LP: #1776807](https://bugs.launchpad.net/snapcraft/+bug/1776807)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | WIP PR never merged; closed unmerged. The implicit-source removal it started landed via snapcraft#2326, merged as commit 42c7820ef, implementing LP #1776807. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged WIP; implicit-source removal was superseded by merged snapcraft#2326 via commit 42c7820ef, implementing LP #1776807. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; snapcraft#2326 replaced this WIP and removed implicit plugin sources via commit 42c7820ef, implementing LP #1776807. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without merging. The WIP branch contained failing unit tests and received no review feedback, leading to the abandonment of the implicit source removal changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed as abandoned without merging. Marked as work in progress, the pull request stalled after the author proposed collaborating on test updates. The changes were never integrated into the codebase. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#2326
(confidence 97%)
Merged PR 'plugins: remove implicit source' (commit 42c7820ef) implements the same LP #1776807 change that #2300 began.
-
Related To:
canonical/snapcraft#2326
(confidence 95%)
Same title and 39-file scope; superseding PR that closed out the work.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2326 plugins: remove implicit source | snapcraft | merged | Merged PR #2326 as commit 42c7820ef, removing implicit plugin sources and implementing LP #1776807; it superseded WIP PR #2300 with revised internal logic. |