plugins: remove implicit source
Metadata
Current evaluation
Merged PR #2326 as commit 42c7820ef, removing implicit plugin sources and implementing LP #1776807; it superseded WIP PR #2300 with revised internal logic.
Resolution: closed resolved
Reason: PR #2326 was merged into master as commit 42c7820ef, removing implicit plugin sources and implementing LP #1776807.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1776807
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This is #2300 but non WIP and with a change of internal logic from the initial commit.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2326 as commit 42c7820ef, removing implicit plugin sources and implementing LP #1776807; it superseded WIP PR #2300 with revised internal logic. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#2326, removing implicit plugin sources to implement LP #1776807. It replaced the earlier unmerged WIP snapcraft#2300 with revised internal logic. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Removes implicit source from plugins, addressing LP: #1776807. Supersedes PR #2300 with updated internal logic and passes code coverage checks. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#2300
(confidence 100%)
Earlier unmerged WIP whose implicit-source removal was reworked and completed by PR #2326.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2300 [WIP] plugins: remove implicit source | snapcraft | closed | WIP PR never merged; closed unmerged. The implicit-source removal it started landed via snapcraft#2326, merged as commit 42c7820ef, implementing LP #1776807. | |
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility. |