plugins: remove implicit source
Metadata
Current evaluation
Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines).
Suggested action: —
No scores available.
Issue body
LP: #1776807
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
This is #2300 but non WIP and with a change of internal logic from the initial commit.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Removes implicit source from plugins, addressing LP: #1776807. Supersedes PR #2300 with updated internal logic and passes code coverage checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, removing implicit source from plugins to resolve Launchpad bug #1776807. Refactors internal logic, passes 81.08% diff coverage, and was signed off by maintainers. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2300 [WIP] plugins: remove implicit source | snapcraft | closed | Closed without merging. The WIP branch contained failing unit tests and received no review feedback, leading to the abandonment of the implicit source removal changes. | |
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files. | |
| #2371 plugins: remove jhbuild | snapcraft | merged | Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks. | |
| #3003 repo: always use host source lists and remove those found in plugins | snapcraft | merged | Merged after approval and CI. Central apt source merging in the Ubuntu object, removed redundant cross-release sources from catkin and colcon plugins, updated tests, and removed unused plugin references. (+39/-109 lines, 7 files) | |
| #2376 jdk plugin: remove jdk | snapcraft | merged | Merged the JDK plugin removal. Approved by a reviewer, passed CI, and deleted 51 lines across three files to address Launchpad bug #1794788. | |
| #27 plugins: add the nil plugin | craft-parts | merged | Merged the nil plugin to handle parts with no source. Approved by two reviewers, passed CI checks, and introduced 109 lines across two files. |