← Back to issue list

plugins: remove the tar-content plugin when using a base

View original Github issue

Metadata

Project
snapcraft
Number
#2319
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged into master. Removes the tar-content plugin when a base is specified to preserve backwards compatibility. Approved by reviewer, passed CI checks, and increased coverage by 0.03%.

Suggested action:

No scores available.

Issue body

The spread tests for the tar-content plugin set no base, they should ensure that backwards compatibility is not broken. LP: #1794804 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. Removes the tar-content plugin when a base is specified to preserve backwards compatibility. Approved by reviewer, passed CI checks, and increased coverage by 0.03%.
qwen3.6-35b-a3b-mtp-q6 Merged into master, the change removes the tar-content plugin when a base is specified to preserve backwards compatibility in spread tests. The update integrated successfully, increasing overall code coverage by 0.03%.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Removed the tar-content plugin when a base is specified to preserve backwards compatibility, resolving LP #1794804. The change reduced code by 26 lines and increased coverage by 0.03%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2308 plugins: remove the copy plugin when using a base snapcraft merged Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files.
83%
#2324 plugins: remove the ament plugin when using a base snapcraft merged Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks.
71%
#2370 ant plugin: add support for bases snapcraft merged Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage.
70%
#2209 tests: add spread suite for tar-content plugin snapcraft merged Merged to master, resolving Launchpad bug #1783845 by migrating tar-content plugin integration tests to a Spread suite. Approved by one reviewer, passed CI, and increased coverage by less than 0.01%.
70%
#2325 plugins: remove the python2 and python3 plugin when using a base snapcraft merged Merged changes remove deprecated python2 and python3 plugins when using a base, consolidating them into a single python plugin. Includes legacy mode checks. Approved, passed CI, and modified 13 files.
70%