plugins: remove the tar-content plugin when using a base
Metadata
Current evaluation
PR #2319 by sergiusens merged into master as commit 0179ba6e0, dropping the legacy tar-content plugin for snaps built on a base (no base), since core/base already handles tar sources.
Resolution: closed resolved
Reason: The PR was approved and merged as commit 0179ba6e0 ("plugins: remove the tar-content plugin when using a base (#2319)"), removing snapcraft/plugins/tar_content.py and its plugin registration/tests for base-based builds; LP: #1794804.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The spread tests for the tar-content plugin set no base, they should
ensure that backwards compatibility is not broken.
LP: #1794804
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #2319 by sergiusens merged into master as commit 0179ba6e0, dropping the legacy tar-content plugin for snaps built on a base (no base), since core/base already handles tar sources. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2319 (commit 0179ba6e0), preventing tar-content from overriding a specified base and preserving backward compatibility. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcore/snapcraft#2319 (commit 0179ba6e0), removing tar-content when a base is specified to preserve backwards compatibility. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Removes the tar-content plugin when a base is specified to preserve backwards compatibility. Approved by reviewer, passed CI checks, and increased coverage by 0.03%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master, the change removes the tar-content plugin when a base is specified to preserve backwards compatibility in spread tests. The update integrated successfully, increasing overall code coverage by 0.03%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#2209
(confidence 70%)
Earlier commit3810b9151 added the base-less spread tests for tar-content that this PR had to account for
-
Caused By:
launchpad#1794804
(confidence 55%)
Referenced Launchpad bug in the PR description (LP: #1794804)
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1794804 Remove the tar-content plugin | snapcraft (launchpad) | closed | Removed the deprecated tar-content plugin for base-based builds via snapcore/snapcraft#2319, committed as 0179ba6e0. | |
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility. |