plugins: remove the copy plugin when using a base
Metadata
Current evaluation
Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility.
Resolution: closed resolved
Reason: The approved PR was merged into master as commit 360453fa6. It removes copy-plugin availability when a base is used and adds spread tests for legacy no-base builds.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The spread tests for the copy plugin set no base, they should ensure
that backwards compatibility is not broken.
LP: #1794781
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2308 via commit 360453fa6, removing the copy plugin for base-based builds while preserving and testing legacy no-base compatibility. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2308 in commit 360453fa6, removing the copy plugin for base-based builds while adding spread tests for legacy no-base compatibility. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates spread tests to verify backwards compatibility when removing the copy plugin with a base, resolving LP #1794781. Diff coverage remained at 100% despite a minor overall decrease. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2324 plugins: remove the ament plugin when using a base | snapcraft | merged | Merged PR #2324 (745c4d311), removing deprecated ament plugin support for base-based builds while retaining legacy-mode reachability through spread tests. | |
| #2325 plugins: remove the python2 and python3 plugin when using a base | snapcraft | merged | Merged #2325 in commit 958b58615, removing deprecated python2/python3 plugins for base builds and retaining legacy-mode regression coverage for the unified python plugin. | |
| #3389 plugins v1: move build base test in v1 plugins to base class | snapcraft | merged | Merged PR #3389 (commit b0d696f07): the per-plugin build-base check for V1 plugins was moved into the V1 Plugin base class constructor, removing duplicated checks across 23 files (+78/-146). | |
| #2319 plugins: remove the tar-content plugin when using a base | snapcraft | merged | PR #2319 by sergiusens merged into master as commit 0179ba6e0, dropping the legacy tar-content plugin for snaps built on a base (no base), since core/base already handles tar sources. | |
| #2371 plugins: remove jhbuild | snapcraft | merged | PR #2371 (commit b46e3f678) by kyrofa merged, deleting the unused, base-incompatible jhbuild plugin (-503 lines, 8 files), resolving LP bug #1794789. No jhbuild references remain in the repo. | |
| #2326 plugins: remove implicit source | snapcraft | merged | Merged PR #2326 as commit 42c7820ef, removing implicit plugin sources and implementing LP #1776807; it superseded WIP PR #2300 with revised internal logic. |