plugins: remove the copy plugin when using a base
Metadata
Current evaluation
Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files.
Suggested action: —
No scores available.
Issue body
The spread tests for the copy plugin set no base, they should ensure
that backwards compatibility is not broken.
LP: #1794781
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updates spread tests to verify backwards compatibility when removing the copy plugin with a base, resolving LP #1794781. Diff coverage remained at 100% despite a minor overall decrease. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. The copy plugin is removed when a base is specified to preserve backwards compatibility. The change achieved 100% diff coverage and was integrated despite a negligible overall coverage drop. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2319 plugins: remove the tar-content plugin when using a base | snapcraft | merged | Merged into master. Removes the tar-content plugin when a base is specified to preserve backwards compatibility. Approved by reviewer, passed CI checks, and increased coverage by 0.03%. | |
| #2199 tests: add spread suite for copy plugin | snapcraft | merged | Merged into master following approval and passing CI. Moves copy plugin integration tests to a spread suite, resolving bug LP: #1783831. Modified 10 files, reduced code by 41 lines, and increased coverage by 0.02%. | |
| #2325 plugins: remove the python2 and python3 plugin when using a base | snapcraft | merged | Merged changes remove deprecated python2 and python3 plugins when using a base, consolidating them into a single python plugin. Includes legacy mode checks. Approved, passed CI, and modified 13 files. | |
| #2370 ant plugin: add support for bases | snapcraft | merged | Merged after approval and CI. Adds base support to the ant plugin, restricting it to core16 and core18. Modifies 14 files with 83.54% diff coverage. | |
| #2371 plugins: remove jhbuild | snapcraft | merged | Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks. | |
| #2324 plugins: remove the ament plugin when using a base | snapcraft | merged | Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks. | |
| #2326 plugins: remove implicit source | snapcraft | merged | Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines). | |
| #353 Skip the BasePlugin from plugin search | snapcraft | merged | Merged changes that skip BasePlugin from the plugin search to support importing it as a symbol instead of a module. Approved by reviewers and passed CI checks. | |
| #3020 spread tests: default base for local plugin tests | snapcraft | merged | Merged updates to spread tests establishing a default base for local plugin tests. The change follows a prior commit pattern, adding two lines across two files. Approved by one reviewer and passed CI checks. | |
| #3389 plugins v1: move build base test in v1 plugins to base class | snapcraft | merged | Merged refactoring that moves build base validation to the V1 plugin base class constructor. The change reduces duplication across 23 files while maintaining checks for core, core16, and core18 bases. |