pluginhandler: remove legacy plugin loading without project
Metadata
Current evaluation
Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase.
Suggested action: —
No scores available.
Issue body
Logic existed to be able to support plugins that did not support
a signature with Project, support for this is removed with the
move to bases.
LP: #1796668
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of legacy plugin loading logic lacking Project signature support, aligning with the bases architecture transition. The change passed code coverage validation and was integrated into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged removal of legacy plugin loading logic that lacked Project signature support, aligning with the move to bases. The change achieved 100% diff coverage and was approved by maintainer sergiusens. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3166 plugin handler: load legacy plugins prefixed with 'x-' | snapcraft | merged | Merged into master to load legacy plugins prefixed with 'x-' for backward compatibility. Approved by one reviewer, passed CI, and modified 9 files. Minor coverage decrease noted but did not block integration. | |
| #3023 pluginhandler: move attributes to PluginHandler | snapcraft | merged | Merged after approval and passing CI. Refactors PluginHandler by moving attributes directly to the class, eliminating duplicates from Project and Project._snap_meta, and cleaning up code across 8 files. | |
| #3017 pluginhandler: deterministic load depending on plugin and build-base | snapcraft | merged | Merged after reviewer approval and passing CI. Replaced unreliable local plugin loading with a deterministic factory that selects pre-imported plugins based on the build-base. Refactored code across 15 files. | |
| #2324 plugins: remove the ament plugin when using a base | snapcraft | merged | Merged. Removed the deprecated ament plugin from snapcraft in favor of newer bases. Legacy mode support is preserved for backward compatibility. Approved by reviewer and passed CI checks. | |
| #2327 pluginhandler: remove prepare, build and install scriptlets | snapcraft | merged | Merged removal of deprecated prepare, build, and install scriptlets from pluginhandler, replaced by override-step-name syntax. Backwards compatibility maintained via integration tests. Approved and passed CI. | |
| #2304 project loader: remove remote parts support for bases | snapcraft | merged | Merged removal of remote parts support for bases. The project loader now errors on undefined parts or missing plugins. CLI commands update, search, and define were removed. Approved and merged after passing CI. | |
| #2308 plugins: remove the copy plugin when using a base | snapcraft | merged | Merged into master. Removes the copy plugin when a base is specified. Updated spread tests to verify backwards compatibility. Approved by reviewer, passed CI, and integrated with a net reduction of 622 lines across eight files. |