← Back to issue list

pluginhandler: remove legacy plugin loading without project

View original Github issue

Metadata

Project
snapcraft
Number
#2329
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR snapcore/snapcraft#2329 by sergiusens merged into master as commit 9eef2b553, deleting legacy plugin loading paths that built plugins without a Project (LP #1796668), made obsolete by the bases migration.

Resolution: closed resolved

Reason: The pull request itself was merged, landing as commit 9eef2b553 ('pluginhandler: remove legacy plugin loading without project (#2329)') after maintainer approval, closing Launchpad bug #1796668. It removed 75 lines of dead legacy loading logic.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Logic existed to be able to support plugins that did not support a signature with Project, support for this is removed with the move to bases. LP: #1796668 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR snapcore/snapcraft#2329 by sergiusens merged into master as commit 9eef2b553, deleting legacy plugin loading paths that built plugins without a Project (LP #1796668), made obsolete by the bases migration.
stealth/space-bunny-alpha — closed resolved Merged #2329 in commit 9eef2b553, removing legacy plugin loading without a project after the move to bases.
qwen/qwen3.6-35b-a3b — — Merged pull request removing legacy plugin loading logic without project support, aligning with the move to bases. Approved by maintainer, passed CI, and successfully integrated into the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged removal of legacy plugin loading logic lacking Project signature support, aligning with the bases architecture transition. The change passed code coverage validation and was integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1796668 (confidence 90%)

    Linked Launchpad bug 'Remove project injection from the pluginhandler' (LP: #1796668), closed by this PR.

  • Related To: snapcore/snapcraft#1507 (confidence 45%)

    Earlier commit f8207335f 'many: simplify plugin loading (#1507)' is part of the same plugin-loading simplification lineage in pluginhandler.py.

Related issues

Issue Project State Summary Similarity
#1796668 Remove project injection from the pluginhandler snapcraft (launchpad) closed Removed pluginhandler legacy project injection for the Snapcraft 3.0 API break; the maintainer linked resolving PR snapcore/snapcraft#2329.
80%
#2361 schema: remove deprecated plugin pull and build-properties snapcraft merged PR #2361 by sergiusens merged (commit b6be1d330), dropping the deprecated plugin pull and build-properties keys from snapcraft.yaml (+1/-115, 5 files), fixing LP bug #1796669.
73%
#1794789 Remove the jhbuild plugin snapcraft (launchpad) closed Maintainer sergiusens asked to drop the unused, non-base-aware jhbuild plugin. Resolved by merged PR snapcore/snapcraft#2371 (commit b46e3f678, "plugins: remove jhbuild", ~503 lines removed); no jhbuild references remain in the tree.
73%