← Back to issue list

schema: remove deprecated plugin pull and build-properties

View original Github issue

Metadata

Project
snapcraft
Number
#2361
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #2361 by sergiusens merged (commit b6be1d330), dropping the deprecated plugin pull and build-properties keys from snapcraft.yaml (+1/-115, 5 files), fixing LP bug #1796669.

Resolution: closed resolved

Reason: The PR was approved by kyrofa and merged into the repository as commit b6be1d330, which deleted the deprecated schema entries. It closes Launchpad bug #1796669 ('Remove outdated checks in schema'), now marked closed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1796669 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #2361 by sergiusens merged (commit b6be1d330), dropping the deprecated plugin pull and build-properties keys from snapcraft.yaml (+1/-115, 5 files), fixing LP bug #1796669.
stealth/space-bunny-alpha — closed resolved Merged PR #2361 removed deprecated plugin pull and build-properties from the schema in commit b6be1d330, resolving LP #1796669.
qwen/qwen3.6-35b-a3b — — Merged schema cleanup removing deprecated plugin pull and build-properties. Approved by reviewer, passed CI, and changed 5 files (+1/-115 lines). Resolves LP: #1796669.
qwen3.6-35b-a3b-mtp-q6 — — Removed deprecated pull and build-properties from the schema. The pull request was merged after tests passed, despite a Travis CI reporting failure.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1796669 (confidence 80%)

    Launchpad bug #1796669 'Remove outdated checks in schema' is referenced in the PR body as the tracking bug and is now closed.

  • Related To: snapcraft (launchpad)#1647899 (confidence 62%)

    Earlier cleanup work that migrated official plugins off the deprecated pull properties, which made removing the schema checks safe.

  • Related To: snapcraft (launchpad)#1650078 (confidence 55%)

    Prior plugin migration (PR #978) replacing schema build-properties mutation with get_build_properties().

Related issues

Issue Project State Summary Similarity
#1796669 Remove outdated checks in schema snapcraft (launchpad) closed Merged snapcore/snapcraft#2361 removed deprecated plugin pull and build-properties schema checks in commit b6be1d330.
75%
#1794789 Remove the jhbuild plugin snapcraft (launchpad) closed Maintainer sergiusens asked to drop the unused, non-base-aware jhbuild plugin. Resolved by merged PR snapcore/snapcraft#2371 (commit b46e3f678, "plugins: remove jhbuild", ~503 lines removed); no jhbuild references remain in the tree.
74%
#2329 pluginhandler: remove legacy plugin loading without project snapcraft merged PR snapcore/snapcraft#2329 by sergiusens merged into master as commit 9eef2b553, deleting legacy plugin loading paths that built plugins without a Project (LP #1796668), made obsolete by the bases migration.
73%
#153 Obsolete deprecations from 1.x snapcraft merged Merged PR #153 as commit a4d8464, removing obsolete Snapcraft 1.x deprecation code and messages across 18 files.
70%