schema: remove deprecated plugin pull and build-properties
Metadata
Current evaluation
Merged schema cleanup removing deprecated plugin pull and build-properties. Approved by reviewer, passed CI, and changed 5 files (+1/-115 lines). Resolves LP: #1796669.
Suggested action: —
No scores available.
Issue body
LP: #1796669
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged schema cleanup removing deprecated plugin pull and build-properties. Approved by reviewer, passed CI, and changed 5 files (+1/-115 lines). Resolves LP: #1796669. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Removed deprecated pull and build-properties from the schema. The pull request was merged after tests passed, despite a Travis CI reporting failure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged schema update removing deprecated plugin pull and build-properties. Tests passed despite a Travis CI reporting glitch. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%. | |
| #93 Validate that 'plugins' is not used as a part name | snapcraft | merged | Merged validation preventing 'plugins' as a part name to avoid local plugin conflicts. Removed commented schema YAML. Approved by @chipaca. Modified 2 files with +12/-4 lines. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged updates to the gulp plugin that replace schema modification with get_build_properties() and get_pull_properties(). Added corresponding plugin and schema tests. | |
| #854 Decouple state handling from plugin options. | snapcraft | merged | Merged the 11-file refactoring to decouple state handling from plugin options. Addressed reviewer feedback by confirming test coverage and adding a schema_properties check. Resolved unrelated CI failures and completed the integration. | |
| #3357 project schema tests: ensure json format checkers are loaded | snapcraft | merged | Merged a fix resolving project schema test failures when run individually. The change imports missing JSON format checkers and suppresses related warnings. Approved by one reviewer, passed CI, and applied with a minimal two-line change. | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Updated the qmake plugin to use get_build_properties() and get_pull_properties() instead of schema modifications, with new tests added. The associated pull request was merged, closing the issue. |