pluginhandler: library detection instead of injection
Metadata
Current evaluation
Merged #2337 in commit 48bb4c162, replacing host-library injection with base-snap detection and warning instead of failing when a library is missing.
Resolution: closed resolved
Reason: PR #2337 was merged as commit 48bb4c162. It detects required libraries from installed base snaps and treats missing libraries as warnings because content snaps may provide them.
Evaluated by: mr-cal-bot
No scores available.
Issue body
With bases, the logic to inject binaries from the host will no longer be
at play. Instead, the base snap for the target project will always be
installed and necessity of the library will be determined throught there
instead
If a library is missing a warning will be issued instead of an error
given the existence of the content snap and its potential use.
LP: #1794556
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2337 in commit 48bb4c162, replacing host-library injection with base-snap detection and warning instead of failing when a library is missing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2337 in commit 48bb4c162, replacing host-library injection with base-snap detection and changing missing-library errors to warnings. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2337 replaced host-library injection with detection from installed base snaps; missing libraries now warn rather than error (48bb4c162). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2337 (commit 48bb4c162), replacing host-library injection with target-base detection and changing missing libraries from errors to warnings. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2337 as commit 48bb4c162, replacing host-library injection with detection in the installed base snap and warning instead of failing on missing libraries. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2337 in commit 48bb4c162, replacing host-library injection with detection in the target base snap and downgrading missing-library failures to warnings. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2337 replaced host-library injection with base-snap library detection, warning instead of failing when a library is missing; commit 48bb4c162. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Replaced host binary injection with library detection via base snaps, converting missing library errors to warnings. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced host binary injection with library detection via base snaps. Missing libraries now trigger warnings instead of errors. Aligns with content snap architecture. Diff coverage at 87.5%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1829 pluginhandler: warn the inclusion of libraries from the host | snapcraft | merged | Merged #1829 in commit 2f2f17b4e, adding a pluginhandler warning when a snap includes libraries from the host. |