pluginhandler: library detection instead of injection
Metadata
Current evaluation
Merged. Replaced host binary injection with library detection via base snaps, converting missing library errors to warnings. Approved by reviewer and passed CI checks.
Suggested action: —
No scores available.
Issue body
With bases, the logic to inject binaries from the host will no longer be
at play. Instead, the base snap for the target project will always be
installed and necessity of the library will be determined throught there
instead
If a library is missing a warning will be issued instead of an error
given the existence of the content snap and its potential use.
LP: #1794556
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Replaced host binary injection with library detection via base snaps, converting missing library errors to warnings. Approved by reviewer and passed CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Replaced host binary injection with library detection via base snaps. Missing libraries now trigger warnings instead of errors. Aligns with content snap architecture. Diff coverage at 87.5%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes replacing host binary injection with library detection via base snaps. Missing libraries now trigger warnings instead of errors, supporting content snap workflows. Resolves LP: #1794556. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1829 pluginhandler: warn the inclusion of libraries from the host | snapcraft | merged | Merged a pull request adding a host library inclusion warning to the pluginhandler. The change modified one file with nine added lines, passed CI checks, and required no reviewer comments. | |
| #3317 plugin handler: properly handle snapcraftctl errors | snapcraft | merged | Merged fix for plugin handler to properly catch snapcraftctl errors. Replaced specific exception handling with a broad catch in the scriptlet runner to prevent silent failures and redundant output. Approved, passed CI, and increased coverage. | |
| #1231 pluginhandler: exclude `/snap/` from libraries. | snapcraft | merged | Merged. Excludes /snap/ paths from library collection during classic confinement builds, preventing unintended inclusion of snap libraries. Approved, passed CI, and resolves LP: #1670100. | |
| #2012 pluginhandler: only do elf checking and patching for type app | snapcraft | merged | Merged changes restricting ELF checking and patching to app-type snaps, removing unnecessary libc6 ABI/API checks for other types. Resolves LP: #1757094. Approved and passed CI. |