← Back to issue list

extensions: cleanup and generic tests

View original Github issue

Metadata

Project
snapcraft
Number
#2355
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1791172](https://bugs.launchpad.net/snapcraft/+bug/1791172) by making sure extensions are properly installable and also adds a few generic tests to smoke test future extensions.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).
qwen3.6-35b-a3b-mtp-q6 Merged cleanup and generic tests for extensions. Ensures proper installation and adds smoke tests for future extensions, resolving Launchpad bug #1791172.
qwen3.6-35b-a3b-mtp-q6 Merged cleanup and generic tests for extensions. Ensures proper installation and adds smoke tests for future extensions, resolving Launchpad bug #1791172.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3781 extensions: refactor snapcraft merged Merged refactoring of extensions to prevent future cyclic import issues. Approved by reviewer, passed CI, and integrated into main. Reduced code by 163 lines across six files with a minor coverage decrease.
80%
#5378 test: fix extension tests snapcraft merged Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge.
75%
#2350 extensions: parse all declared extensions before applying snapcraft merged Merged to resolve LP: #1797638 by parsing all declared extensions before applying them, fixing conflicts when multiple apps share an extension. Approved, passed CI, and achieved 100% diff coverage.
74%
#292 extensions: add cli commands rockcraft merged Merged addition of list-extensions and expand-extensions CLI commands matching Snapcraft semantics, plus test refactoring. Resolves #274. Approved by two reviewers, passed CI, and modified 15 files (+452/-109 lines).
74%
#2705 extensions: rename extension classes to known names snapcraft merged Merged changes renaming extension classes to known names, simplifying logic by removing string parsing for Extension class implementation. Approved, passed CI, and increased coverage by 0.01% across five files.
73%
#2348 extensions: remove root extensions snapcraft merged Merged removal of root extension declarations from snapcraft.yaml. Resolves LP #1797631 by deferring application scope decisions until usage patterns clarify. Approved by maintainer, passed CI, and modified two files.
72%
#2236 extensions: fix install path snapcraft merged Merged fix for extension installation path, changing directory from extensions-data to extensions. Resolves Launchpad bug #1790197. Approved, passed CI, and merged with a single line change.
72%
#1097 fix: spread tests and tutorials for extentions with default base bare rockcraft merged Merged. Updated spread tests and tutorials to align with extensions now using bare as the default base. Approved by three reviewers and passed CI after resolving initial failures. Modified 17 files.
72%
#2701 spread tests: update gnome extension tests snapcraft merged Merged updates to gnome extension tests, restricting content snap availability to supported architectures. Changes clean up summaries and unify the base logic setup across test files. Approved with passing CI checks.
71%
#4705 docs(extensions): improve docstrings and comments snapcraft merged Improved docstrings and comments for extensions, clarifying the builtin parameter. Merged after approval by two reviewers, passing all CI checks and code coverage requirements. Modified two files with 28 additions and 4 deletions.
71%