← Back to issue list

extensions: cleanup and generic tests

View original Github issue

Metadata

Project
snapcraft
Number
#2355
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2355 in commit 1c2a609a5, fixing LP #1791172 by making extensions properly installable and adding generic extension smoke tests.

Resolution: closed resolved

Reason: PR #2355 was approved and merged, landing as commit 1c2a609a5. It resolves LP #1791172 and adds generic smoke tests for future extensions.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh tests/unit`? ----- This PR resolves [LP: #1791172](https://bugs.launchpad.net/snapcraft/+bug/1791172) by making sure extensions are properly installable and also adds a few generic tests to smoke test future extensions.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2355 in commit 1c2a609a5, fixing LP #1791172 by making extensions properly installable and adding generic extension smoke tests.
stealth/space-bunny-alpha — closed resolved Merged #2355 via commit 1c2a609a5, fixing extension installability and adding generic smoke tests for future extensions.
stealth/space-bunny-alpha — closed resolved Merged PR #2355 fixed LP #1791172 by making extensions properly installable and adding generic smoke tests for future extensions.
qwen/qwen3.6-35b-a3b — — Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).
qwen3.6-35b-a3b-mtp-q6 — — Merged cleanup and generic tests for extensions. Ensures proper installation and adds smoke tests for future extensions, resolving Launchpad bug #1791172.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5378 test: fix extension tests snapcraft merged Merged #5378 in commit 510908ecd, correcting expand_extensions() unit tests; core22 and core24 already behaved correctly, so no production changes were needed.
75%
#2236 extensions: fix install path snapcraft merged Merged PR #2236 corrected the extension-part install path from extensions-data to extensions, resolving LP #1790197 in commit f48b08f1e.
74%
#3781 extensions: refactor snapcraft merged Merged in snapcraft#3781 via commit 986a9895b (merge 52155ff01), centralizing extension checks in the base class to prevent future cyclic imports.
73%
#2349 extensions: use extension docstring snapcraft merged Merged PR #2349 in commit 6e7e30ee1, making snapcraft extensions display extension-specific docstrings and resolving LP #1797655.
70%