← Back to issue list

test: fix extension tests

View original Github issue

Metadata

Project
snapcraft
Number
#5378
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #5378 in commit 510908ecd, correcting expand_extensions() unit tests; core22 and core24 already behaved correctly, so no production changes were needed.

Resolution: —

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Unit test fixes for `expand_extensions()`. This ended up being simpler than expected, as `expand_extensions()` and `apply_root_packages()` are working as expected for core22 and core24 and no code changes were needed. (CRAFT-4416)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — — Merged #5378 in commit 510908ecd, correcting expand_extensions() unit tests; core22 and core24 already behaved correctly, so no production changes were needed.
stealth/space-bunny-alpha — — Merged #5378 in commit 510908ecd, fixing expand_extensions() unit tests; core22/core24 behavior was already correct, so no production-code change was needed.
stealth/space-bunny-alpha — closed resolved Merged #5378 in commit 510908ecd, correcting unit tests for expand_extensions(); no production changes were needed because core22 and core24 already behaved correctly.
qwen/qwen3.6-35b-a3b — — Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged unit test updates for expand_extensions(). Verified existing functions work correctly for core22 and core24, requiring only test adjustments rather than code changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2355 extensions: cleanup and generic tests snapcraft merged Merged PR #2355 in commit 1c2a609a5, fixing LP #1791172 by making extensions properly installable and adding generic extension smoke tests.
75%
#417 test: fix typos in extension and terminate services fetch-service merged Merged PR #417 corrected typos in the spread extension and terminate-services test code, landing as commit 8363f15.
73%
#5209 tests: enable core24 plugin tests snapcraft merged Merged PR #5209 as commit 56713c384, enabling core24 plugin tests across 132 files and expanding core24 test coverage.
73%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
72%
#4595 tests(spread): remove core24 ros2 extension linter tests snapcraft merged Merged PR #4595 (commit 043584583) removing Core 24 ROS 2 extension linter spread tests from five files, since ROS for 24.04 and its extension do not exist. Approved by 2 reviewers.
70%