← Back to issue list

test: fix extension tests

View original Github issue

Metadata

Project
snapcraft
Number
#5378
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Unit test fixes for `expand_extensions()`. This ended up being simpler than expected, as `expand_extensions()` and `apply_root_packages()` are working as expected for core22 and core24 and no code changes were needed. (CRAFT-4416)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged unit test updates for expand_extensions(). Verified existing functions work correctly for core22 and core24, requiring only test adjustments rather than code changes.
qwen3.6-35b-a3b-mtp-q6 Merged test update fixing unit tests for expand_extensions(). No code changes were needed as the function works correctly for core22 and core24. Resolves CRAFT-4416.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4606 feat(app): support extensions in core24 snapcraft merged Added extension support to core24. Merged after approval by two reviewers, passing all CI checks with 100% coverage on modified lines. The change updated nine files, adding 183 lines and removing 30.
77%
#2355 extensions: cleanup and generic tests snapcraft merged Resolved LP: #1791172 by ensuring extensions are properly installable and adding generic smoke tests for future extensions. Merged after approval and passing CI, modifying 10 files (+133/-17).
75%
#3798 extensions: add core22 gnome snapcraft merged Merged into main. Added core22 gnome extension support. Approved by reviewer, passed CI, and increased test coverage by 0.09%. Changes modified 10 files with 707 additions and 1 deletion.
74%
#3668 extensions: support core22 snapcraft merged Merged into snapcraft/7.0. Implements core22 support for extensions by updating the API and processing pipeline. Confirmed apply_extensions compatibility, passed code review and CI, and increased coverage by 1.43%.
74%
#4600 fix(tests): core24 classic linter test expectations snapcraft merged Merged after approval and passing CI. The change updates core24 classic linter test expectations. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer later flagged a separate core22 spread failure.
74%
#1097 fix: spread tests and tutorials for extentions with default base bare rockcraft merged Merged. Updated spread tests and tutorials to align with extensions now using bare as the default base. Approved by three reviewers and passed CI after resolving initial failures. Modified 17 files.
73%
#4595 tests(spread): remove core24 ros2 extension linter tests snapcraft merged Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files.
72%
#5375 test: fix command tests snapcraft merged Merged after updating test fixtures to resolve failing command unit tests. Approved by two reviewers, passed CI checks, and modified two files with 17 additions and 9 deletions.
72%
#5209 tests: enable core24 plugin tests snapcraft merged Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch.
72%
#3731 tests: fix content provider snap not found for core22 snapcraft merged Merged following reviewer approval and successful CI. Adjusted spread test expectations to match core22's distinct error message for missing content provider snaps. Modified three files, increasing test coverage by 0.08%.
72%