← Back to issue list

jdk plugin: remove jdk

View original Github issue

Metadata

Project
snapcraft
Number
#2376
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged the JDK plugin removal. Approved by a reviewer, passed CI, and deleted 51 lines across three files to address Launchpad bug #1794788.

Suggested action:

No scores available.

Issue body

LP: #1794788 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the JDK plugin removal. Approved by a reviewer, passed CI, and deleted 51 lines across three files to address Launchpad bug #1794788.
qwen3.6-35b-a3b-mtp-q6 Merged the removal of the JDK plugin to resolve Launchpad bug #1794788. The maintainer proceeded with the merge despite a Codecov notification about missing coverage uploads.
qwen3.6-35b-a3b-mtp-q6 Merged PR #2376 to remove the JDK plugin from the codebase, resolving LP #1794788. The change was integrated into master despite a missing Codecov coverage report for the base commit.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2371 plugins: remove jhbuild snapcraft merged Merged removal of the unused, bases-incompatible jhbuild plugin, resolving LP #1794789. The change deletes 503 lines across 8 files following reviewer approval and passing CI checks.
77%
#1905 Remove dangling symlink from JDK plugin (LP Bug #1617296) snapcraft closed Closed without merging. The proposed fix was deemed unnecessary after a bases refactor resolved the dangling symlink issue. Superseded by architectural changes.
71%
#2326 plugins: remove implicit source snapcraft merged Merged. Removes implicit source from plugins, resolving Launchpad bug #1776807. Approved, passed CI, and refined internal logic from PR #2300. Updated 46 files (+84/-59 lines).
70%