← Back to issue list

runtests: run black with --diff

View original Github issue

Metadata

Project
snapcraft
Number
#2391
Type
pull request
State
merged
Author
abitrolly
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2391, updating runtests.sh to run Black with --diff so formatting failures show exact differences.

Resolution: closed resolved

Reason: PR #2391 was merged as commit 2ec5743b7. Its one-line change made static tests invoke Black with --diff, exposing exact formatting differences.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This helps to see the exact error and save some time on checking out and rerunning the check locally. - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2391, updating runtests.sh to run Black with --diff so formatting failures show exact differences.
stealth/space-bunny-alpha — closed resolved Merged PR #2391, adding --diff to Black in runtests so formatting failures show exact changes; merged as commit 2ec5743b7.
qwen/qwen3.6-35b-a3b — — Merged a one-line update to runtests that adds the --diff flag to black, improving CI error visibility. Approved by one reviewer, passed all checks, and integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updated runtests to execute black with --diff, providing exact formatting diffs in CI to speed up local debugging. Despite initial spread test failures, the change was accepted and integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2603 black: minor format changes from updated black snapcraft merged Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
75%