black: minor format changes from updated black
Metadata
Current evaluation
Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
Resolution: closed resolved
Reason: The PR itself was merged into master as commit b442ea48d ("black: minor format changes from updated black (#2603)"), with one approving review and no unresolved review comments. It followed the earlier Black upgrade in #2599 (05913cd56) and the subsequent beta-channel pin in #2606 (adb41b016).
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Chris Patterson <chris.patterson@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2603 (commit b442ea48d): reapplied Black's updated formatting, changing 4 files (+4/-6) with no functional changes. Approved by a maintainer; only a Codecov no-coverage comment. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2603 (commit b442ea48d), applying minor formatting changes from an updated Black formatter across four files. | |
| qwen/qwen3.6-35b-a3b | — | — | Minor formatting updates from the updated black code formatter were reviewed, approved, passed CI checks, and successfully merged into the main branch. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged minor formatting updates applied by the Black code formatter. The pull request passed static checks, achieved 100% diff coverage per Codecov, and was successfully integrated into the main branch. |
Update history
No update history recorded yet.
Related work
-
Caused By:
snapcraft#2599
(confidence 85%)
Prior merged PR updating Snapcraft to the newer Black version, whose output differences needed this follow-up reformat.
-
Related To:
snapcraft#2606
(confidence 65%)
Follow-up PR pinning Black to its beta channel, keeping the formatting produced by this PR stable.
-
Related To:
snapcraft#2391
(confidence 40%)
Earlier PR adding --diff to black in runtests, the check these formatting changes satisfy.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2599 static: update to newer black | snapcraft | merged | Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56. | |
| #3722 static: black update to 22 syntax | snapcraft | merged | Merged PR #3722 (branch 'black', commit 3afcb2ade, merge commit 24ce5d5b0) into main, reformatting 55 files for Black 22 syntax; a prerequisite cleanup for the later switch from black to the ruff formatter. | |
| #3853 lint: lint legacy code with black | snapcraft | merged | Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting. | |
| #2391 runtests: run black with --diff | snapcraft | merged | Merged PR #2391, updating runtests.sh to run Black with --diff so formatting failures show exact differences. | |
| #638 style: update to black 2024 | craft-parts | merged | Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627. | |
| #3865 lint: lint legacy code with black | snapcraft | merged | Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04). | |
| #315 style: use black for consistent and automated formatting | charmcraft | merged | Merged Black formatting across 36 files, added a formatting test, and ignored flake8 E203/W503 for Black compatibility in charmcraft#315 (merge commit ad135981). | |
| #446 Configure black in 99 columns. | charmcraft | merged | Merged #446, setting Black to 99 columns and reformatting 39 files; changes landed in faf6125f and merged as db9b3cdf. | |
| #3650 lint: apply autoformat-black to source files | snapcraft | merged | Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4. | |
| #3787 lint: apply black to parts directories | snapcraft | merged | Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored. |