← Back to issue list

cmake plugin: use native primitives

View original Github issue

Metadata

Project
snapcraft
Number
#2397
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged into master. The cmake plugin replaces make with native primitives, enabling alternative build generators like ninja. Approved by reviewer, passed CI, and integrated successfully.

Suggested action:

No scores available.

Issue body

Remove the dependency on make and use native primitives to build using cmake instead. This allows the build to be configured to use e.g.; ninja. LP: #1802314 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into master. The cmake plugin replaces make with native primitives, enabling alternative build generators like ninja. Approved by reviewer, passed CI, and integrated successfully.
qwen3.6-35b-a3b-mtp-q6 Merged. Replaced make dependency in the cmake plugin with native build primitives, enabling alternative generators like ninja. Approved by maintainers and merged following code review and coverage checks.
qwen3.6-35b-a3b-mtp-q6 Merged into master. Replaced the make dependency in the cmake plugin with native CMake primitives, enabling alternative build generators like Ninja. Approved by @hsitter and integrated despite a minor coverage decrease.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1802314 use cmake primitives instead snapcraft (launchpad) closed Closed without discussion. The request to replace the make plugin with native cmake build and install primitives was abandoned, with no resolution or implementation details recorded.
77%
#3165 Update cmake plugin to support Ninja generator snapcraft merged Merged. Adds a cmake-generator plugin option to enable Ninja builds, leveraging CMake 3.15+ features. Reviewer suggestions were acknowledged, and the update was successfully integrated.
72%