← Back to issue list

cmake plugin: use native primitives

View original Github issue

Metadata

Project
snapcraft
Number
#2397
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged #2397 as commit 305304e83, replacing make-based builds with CMake-native primitives so generators such as Ninja can be used.

Resolution: closed resolved

Reason: PR #2397 was approved and merged into master as commit 305304e83. It removed the CMake plugin's dependency on make and enabled native use of alternative generators such as Ninja.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove the dependency on make and use native primitives to build using cmake instead. This allows the build to be configured to use e.g.; ninja. LP: #1802314 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #2397 as commit 305304e83, replacing make-based builds with CMake-native primitives so generators such as Ninja can be used.
stealth/space-bunny-alpha — closed resolved Merged #2397, replacing make with CMake-native build primitives so the cmake plugin can use generators such as Ninja without depending on make.
stealth/space-bunny-alpha — closed resolved Merged PR #2397 as commit 305304e83, replacing the cmake plugin's make dependency with native CMake primitives and enabling alternative generators such as Ninja.
qwen/qwen3.6-35b-a3b — — Merged into master. The cmake plugin replaces make with native primitives, enabling alternative build generators like ninja. Approved by reviewer, passed CI, and integrated successfully.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Replaced make dependency in the cmake plugin with native build primitives, enabling alternative generators like ninja. Approved by maintainers and merged following code review and coverage checks.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1802314 use cmake primitives instead snapcraft (launchpad) closed CMake switched from the make plugin to native build primitives via merged snapcore/snapcraft#2397 (commit 305304e83).
78%
#2399 cmake plugin: use build snaps to search paths snapcraft merged Merged PR #2399 (commit e2f7f38e6): cmake plugin now derives search paths from build snaps, adding them to CMAKE_FIND_ROOT_PATH. Builds on #2397 native primitives.
70%