cmake plugin: use build snaps to search paths
Metadata
Current evaluation
Merged PR #2399 (commit e2f7f38e6): cmake plugin now derives search paths from build snaps, adding them to CMAKE_FIND_ROOT_PATH. Builds on #2397 native primitives.
Resolution: closed resolved
Reason: PR was merged to master as commit e2f7f38e6, changing snapcraft/plugins/cmake.py (+155/-13) so the CMake plugin pulls build snaps into its search paths. This implements Launchpad bug #1802326, and the diff was approved by a maintainer reviewer (@hsitter).
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2399 (commit e2f7f38e6): cmake plugin now derives search paths from build snaps, adding them to CMAKE_FIND_ROOT_PATH. Builds on #2397 native primitives. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2399 (commit e2f7f38e6), updating the CMake plugin to use build snaps for search paths. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated the cmake plugin to use build snaps for path searching. Approved by a reviewer with 96.29% diff coverage across two files (+155/-13 lines). | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the cmake plugin to use build snaps for path searching. Changes passed code coverage checks and received positive review before integration. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1802326
(confidence 88%)
Launchpad bug 'leverage CMAKE_FIND_ROOT_PATH for build snaps in the cmake plugin' — the bug this PR implements.
-
Related To:
snapcraft#2397
(confidence 80%)
Predecessor commit 305304e83 (cmake plugin: use native primitives) is the base this PR was merged on top of.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1802326 leverage CMAKE_FIND_ROOT_PATH for build snaps in the cmake plugin | snapcraft (launchpad) | closed | Implemented by merged PR #2399 as commit e2f7f38e6, making the CMake plugin search build-snap paths. | |
| #1794780 Update the cmake plugin to be base aware | snapcraft (launchpad) | closed | Base-aware CMake support landed via canonical/snapcraft#2399 (commit e2f7f38e6), adding build-snap search paths. | |
| #1802314 use cmake primitives instead | snapcraft (launchpad) | closed | CMake switched from the make plugin to native build primitives via merged snapcore/snapcraft#2397 (commit 305304e83). | |
| #2397 cmake plugin: use native primitives | snapcraft | merged | Merged #2397 as commit 305304e83, replacing make-based builds with CMake-native primitives so generators such as Ninja can be used. |