multipass: avoid stdin where possible
Metadata
Current evaluation
Merged. Fixes multipass metrics UI conflicts by redirecting unused stdin to subprocess.DEVNULL. Approved by two reviewers, passed CI, and integrated with 41 additions and 29 deletions across two files.
Suggested action: —
No scores available.
Issue body
multipass commands that do not require stdin should have it point to
subprocess.DEVNULL to avoid multipass' metrics UI
LP: #1803445
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged. Fixes multipass metrics UI conflicts by redirecting unused stdin to subprocess.DEVNULL. Approved by two reviewers, passed CI, and integrated with 41 additions and 29 deletions across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to redirect stdin to subprocess.DEVNULL for multipass commands that do not require it, preventing interference with the multipass metrics UI. Resolves LP #1803445. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Redirects stdin to subprocess.DEVNULL for multipass commands to prevent metrics UI interference, resolving Launchpad bug #1803445. Despite missing base coverage in Codecov, the fix was successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2961 build providers: remove over use of -i in sudo | snapcraft | merged | Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files. | |
| #2784 [multipass] use stdio to get data in/out of Multipass | snapcraft | merged | Switched Multipass data transfer to stdio for reliable operation under strict confinement. Refactored into push_file and pull_file functions, removed --cloud-init support. Approved and merged after passing CI checks. |