← Back to issue list

build providers: remove over use of -i in sudo

View original Github issue

Metadata

Project
snapcraft
Number
#2961
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #2961 as commit 54528c17f, removing unnecessary sudo -i flags from build-provider commands to prevent Multipass ioctl warnings when stdin is /dev/null.

Resolution: closed resolved

Reason: PR #2961 was approved and merged as commit 54528c17f. The change removes unnecessary sudo -i usage that caused ioctl warnings when Multipass supplied /dev/null as stdin.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Using -i when stdin is set to DEVNULL causes an ioctl warning in Multipass. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #2961 as commit 54528c17f, removing unnecessary sudo -i flags from build-provider commands to prevent Multipass ioctl warnings when stdin is /dev/null.
stealth/space-bunny-alpha — closed resolved Merged PR #2961 (commit 54528c17f) by maintainer sergiusens, dropping unnecessary sudo -i flags from build-provider commands to stop Multipass ioctl warnings when stdin is /dev/null.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#2961 in commit 54528c17f, removing unnecessary sudo -i flags from build-provider commands to prevent Multipass ioctl warnings when stdin is /dev/null.
qwen/qwen3.6-35b-a3b — — Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Removed unnecessary sudo -i flags from build providers to resolve an ioctl warning in Multipass when stdin is set to DEVNULL.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2447 build providers: remove SIGUSR1 signal ignore workaround for multipass snapcraft merged Merged PR #2447 (commit a2ef08109) removed Snapcraft's SIGUSR1-ignore workaround after Multipass fixed the underlying bug upstream in canonical/multipass#221.
73%