build providers: remove over use of -i in sudo
Metadata
Current evaluation
Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files.
Suggested action: —
No scores available.
Issue body
Using -i when stdin is set to DEVNULL causes an ioctl warning in
Multipass.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed unnecessary sudo -i flags from build providers to resolve an ioctl warning in Multipass when stdin is set to DEVNULL. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix removing unnecessary -i flags from sudo commands in build providers. This prevents ioctl warnings in Multipass when stdin is set to DEVNULL. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2447 build providers: remove SIGUSR1 signal ignore workaround for multipass | snapcraft | merged | Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval. | |
| #2869 build providers: use multipass from stable | snapcraft | merged | Merged update to consume Multipass 1.0 from the stable channel for build providers. Approved by one reviewer, modifying four files with minimal changes. | |
| #2408 multipass: avoid stdin where possible | snapcraft | merged | Merged. Fixes multipass metrics UI conflicts by redirecting unused stdin to subprocess.DEVNULL. Approved by two reviewers, passed CI, and integrated with 41 additions and 29 deletions across two files. | |
| #2511 build providers: modify the _run signature | snapcraft | merged | Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks. | |
| #3275 cli: ignore sudo warning when using multipass | snapcraft | merged | Merged a pull request that updates the CLI to ignore sudo warnings when using multipass. The change (+8/-2 lines in one file) was approved by one reviewer, passed CI checks, and successfully integrated into the main branch. | |
| #2345 build providers: remove the qemu implementation | snapcraft | merged | Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks. | |
| #2284 build providers: make use of time for multipass stop | snapcraft | merged | Updated build providers to use time for Multipass stop operations, resolving Launchpad bug #1793288. Merged after approval and passing CI checks across four files. | |
| #2940 build providers: remove use of cloud-init | snapcraft | merged | Merged changes removing cloud-init from build providers. Refactored to use _run and _push_file methods, isolating initial setup. Approved by reviewer, passed CI, and updated six files. |