meta: make hooks executable instead of complaining they're not
Metadata
Current evaluation
Merged into master. Hooks are now made executable instead of triggering an error, resolving bug #1812003. The change passed CI, received approval, and achieved 100% diff coverage. Whitelisting was deferred to a follow-up PR.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Fixes https://bugs.launchpad.net/snapcraft/+bug/1812003
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Hooks are now made executable instead of triggering an error, resolving bug #1812003. The change passed CI, received approval, and achieved 100% diff coverage. Whitelisting was deferred to a follow-up PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged, resolving bug #1812003 by making hooks executable instead of raising errors. Achieved 100% diff coverage with negligible overall decrease. Future whitelisting logic will be handled separately. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for bug #1812003 to make hooks executable instead of raising errors. Whitelisting deferred to another PR. Achieved 100% diff coverage with negligible overall decrease. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2441 legacy/meta: make hooks executable instead of complaining they're not | snapcraft | merged | Merged cherry-pick of #2440 that fixes bug #1812003 by making hooks executable instead of raising an error. Approved by one reviewer, passed CI, and modified 2 files. | |
| #2478 meta: handle symlinked hooks | snapcraft | merged | Merged PR #2478 resolves a regression from #2440 that broke symlinked hooks. The fix prevents FileNotFoundErrors during permission changes by properly resolving symlinks before stat operations. Approved, passed CI, and merged into master. | |
| #1812003 hooks should be made executable instead of erroring out | snapcraft (launchpad) | closed | Automatic executable permission for hooks was implemented via merged pull request #2440. Snapcraft now sets hook permissions automatically instead of raising an error. | |
| #3386 meta: don't overwrite preconfigured hooks with stubs | snapcraft | merged | Merged a fix that prevents hook stub generation from overwriting existing preconfigured hooks by verifying script existence first. Includes unit tests and passed CI. | |
| #2481 meta: handle symlinked hooks (#2478) | snapcraft | merged | Merged a fix for a regression in symlinked hook handling that caused FileNotFoundErrors during permission changes. Approved by reviewer, passed CI, and updated 2 files to safely resolve symlinks before stat operations. |