legacy/meta: make hooks executable instead of complaining they're not
Metadata
Current evaluation
Merged into legacy in #2441, cherry-picking #2440 (c2f5a0dc0), so hook files are made executable instead of causing a permissions error; fixes Launchpad bug #1812003.
Resolution: closed resolved
Reason: PR #2441 was approved and merged into legacy. It cherry-picked #2440, committed on master as c2f5a0dc0, to make hook files executable rather than reject them.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Fixes https://bugs.launchpad.net/snapcraft/+bug/1812003
This is a cherry-pick of #2440
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged into legacy in #2441, cherry-picking #2440 (c2f5a0dc0), so hook files are made executable instead of causing a permissions error; fixes Launchpad bug #1812003. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2441 into legacy, cherry-picking #2440 to make non-executable hooks executable instead of rejecting them; fixes Launchpad bug #1812003. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2441, a cherry-pick of #2440, made legacy/meta hooks executable instead of rejecting them and fixed Launchpad bug #1812003. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged cherry-pick of #2440 that fixes bug #1812003 by making hooks executable instead of raising an error. Approved by one reviewer, passed CI, and modified 2 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to legacy/meta as a cherry-pick of PR #2440. Updates hook handling to make them executable rather than raising an error, resolving bug #1812003. Diff coverage is 100%. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#2440
(confidence 100%)
Original master implementation cherry-picked by PR #2441.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2440 meta: make hooks executable instead of complaining they're not | snapcraft | merged | PR #2440 by Saviq merged to master as commit c2f5a0dc0: snapcraft's meta no longer errors on non-executable hook scripts and instead chmods them +x. Fixes Launchpad bug #1812003. | |
| #1812003 hooks should be made executable instead of erroring out | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#2440 (commit c2f5a0dc0), which packages recognized hooks as executable instead of rejecting non-executable source files. |