← Back to issue list

Add core18 support to dotnet plugin

View original Github issue

Metadata

Project
snapcraft
Number
#2445
Type
pull request
State
closed
Author
ed10vi
Labels
—
Created
Updated
Closed

Current evaluation

Closed unmerged after a maintainer requested required unit and spread tests; core18 support was later added by merged PR #3005 (d976a8988).

Resolution: closed stale

Reason: The maintainer closed it on 2019-04-01, stating it could be reopened if work resumed; no tests were added and this PR had no resolving commit. PR #3005 later implemented core18 support in commit d976a8988.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed stale Closed unmerged after a maintainer requested required unit and spread tests; core18 support was later added by merged PR #3005 (d976a8988).
stealth/space-bunny-alpha — closed stale core18 support for the dotnet plugin was abandoned after maintainers requested unit and spread tests; no tests were added and the PR was closed without a resolving commit.
qwen/qwen3.6-35b-a3b — — Abandoned. Missing unit and spread tests were requested. The contributor did not update the changes, so the pull request was closed. The team suggested reopening if work resumes or filing a bug report.
qwen3.6-35b-a3b-mtp-q6 — — Core18 support for the dotnet plugin was abandoned. Reviewers requested missing unit and spread tests, but the author did not update the changes, resulting in the pull request being closed without merging.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#3005 (confidence 99%)

    Merged PR #3005 added configurable .NET runtime-version handling and core18 support in commit d976a8988.

Related issues

Issue Project State Summary Similarity
#5534 Add unit and spread tests for the .NET (v2) plugin snapcraft merged Merged in #5534 via commit 18417a277, adding unit and spread coverage for .NET v2, core24 registration, and a dotnet-hello build-and-run test.
72%
#4177 core18: removal snapcraft merged Merged PR snapcore/snapcraft#4177 (May 2023) dropped core18 base support and its unit/spread tests, fixing #4165 via commits 40136ea9b, 77edc734b and ed423b6a8; core18 was EOL.
71%